SplitDateTimeWidget (or MultiWidget) doesn't allow different attrs for different fields

[ciantic@…]

Many times it is needed to have for instance different class attribute value for DateField than TimeField, therefore SplitDateTimeWidget should have a way to give different attrs for time and datefields.
(e.g. Javascript helpers, one with contrib.admin is good example)

There are two ways to fix the problem:
1.) add the possiblity to MultiWidget and let SplitDateTimeWidget merely use the ability or,
2.) add the possiblity to SplitDateTimeWidget

First method is semantically a bit more correct, but requires more than few seconds of implementation (Currently I'm out of time and I can't spare to implement patch for first approach).

Here is the patch for second approach (note that for the second approach leaving the multiwidget attrs as None was sufficient)

[ciantic@…]

Second approach to the problem

[MichaelBishop]

Appears to be a design decision based on the options presented in the description.

If the first approach is chosen, then a patch is required. If the second approach is chosen, then the patch needs to be evaluated.

[Collin Anderson]

Is this a duplicate of #4117?

[Jacob]

The first solution (making the fix to MultiWidget) is the right way to go.

[Julien Phalip]

#14718 was closed as duplicate. See also #16754 for a related issue.

[Julien Phalip]

#10343 was also closed as dupe.

[Jacob]

And other: #16754.

[Koen Biermans]

patch allow list of attrs into multiwidget

[Koen Biermans]

Attaching a patch that allows passing a list of attrs into the multiwidget (first approach).

Includes some simple tests.

No documentation yet.

[James Kirsop]

Would love to see this reviewed at some stage. It would be particularly helpful in supporting the "placeholder" attribute.

[Claude Paroz]

Before this is reviewed, we should have a pull request with the proposed patch, including tests and docs.

[Mariusz Felisiak]

I think that this is a issue specific for SplitDateTimeWidget and SplitHiddenDateTimeWidget, because in general you can get the same result in a different way e.g.:

MultiWidget(
    widgets=(
        Input(attrs={'class': 'foo'}),
        Input(attrs={'class': 'bar'}),
    )
)

IMO there is no need to complicate MultiWidget.

​PR

[Tim Graham <timograham@…>]

In 0034e9a:

Fixed #5851 -- Allowed specifying different HTML attrs for SplitDateTimeWidget subwidgets.

Thanks Tim Graham and Nick Pope for review.