post_syncdb signal callbacks: argument 'created_models' is sometimes a list, sometimes a set

[sam@…]

I have a function hooked up to the post_syncdb signal. When the function is called as a result of running the 'syncdb' management command, the created_models argument is a set. But when the function is called from the 'flush' management command, the created_models argument is a list.

def type_test (sender, app, created_models, verbosity, interactive):
    print type (created_models)
dispatcher.connect (type_test, signal = signals.post_syncdb)

$ p/manage.py test
...
<type 'set'>
<type 'set'>
<type 'set'>
...
<type 'list'>
<type 'list'>
<type 'list'>

This is a problem because one of my functions checks to see if it actually has to do something with a for loop that looks like for m in created_models.intersection (django.db.models.get_models (app)). I don't mind changing that to something that works with both lists and sets, but it would be nice if this inconsistency was cleaned up anyway.

[Pete Crosier]

Make flush use set for created_models

[Chris Beaven]

Perhaps the syncdb signal should be made to return a list instead?

[Pete Crosier]

Make syncdb use a list for created_models instead

[Pete Crosier]

That does make more sense (also, the wiki says to expect created_models as a list) - patch attached.

[Russell Keith-Magee]

This should be a set. It's not ordered, you can't have duplicates, and membership of collection is an important operation.

[Russell Keith-Magee]

Actually -- looking at the patch, it's pretty much RFC, although the patch needs to be updated (since the Python 2.3 protection is no longer required).

[Malcolm Tredinnick]

(In [13768]) Always pass models in post_syncdb signals as a set (not as a list
sometimes).

Fixed #5848, thanks to PJCrosier.