Any template tag that uses Variable instead of parser.compile_filter does not handle filters.

[sneeu]

On a page with the URL '/account/login/', I would expect the following to work:

{% ifequal request.path|slice:"9" "/account/" %}Do something for account pages.{% endifequal %}

As I understand it the underlying code (for ifequal and other template tag) uses resolve_variable so the first argument becomes:

request.get('path|slice:":9"')

Currently a workaround using the 'with' template tag is required:

{% with request.path|slice:"9" as path_prefix %}Do something ...{% endwith %}

[Collin Grady <cgrady@…>]

Only tag I saw that still did this was ifequal/ifnotequal - patch attached

[Chris Beaven]

Checking source, we should probably fix this across the board (better to be consistent). Needs to be done for:

• {% cycle %}
• {% ifchanged %}
• {% ifequal %}
• {% firstof %}
• {% include %} (in loader_tags)

[Antti Kaihola]

Replying to SmileyChris:

• {% cycle %}
  
• {% ifchanged %}
  
• {% ifequal %}
  
• {% firstof %}
  
• {% include %} (in loader_tags)

Enabling filter expressions as arguments to these tags turns out to be a bit complicated. Django's unit tests are full of single-quoted arguments to these tags, but compile_filter() (or actually FilterExpression) only supports double quotes. There are also issues with escaping quotes and translation.

These problems should be solved (#7295 has one possible patch) before going forward with this ticket.

[Antti Kaihola]

Filters as arguments for cycle, firstof, ifchanged, ifequal and include. Depends on #7295.

[Antti Kaihola]

The current patch for #7295 together with 5756.2.patch​ pass all current tests and make it possible to use filter expressions as arguments for the above mentioned five template tags.

Tests for the new feature should probably be added.

[anonymous]

Replying to SmileyChris:

Checking source, we should probably fix this across the board (better to be consistent). Needs to be done for:

• {% cycle %}
• {% ifchanged %}
• {% ifequal %}
• {% firstof %}
• {% include %} (in loader_tags)

It is probably too late in the game to bring this up, but should simple_tag handle this as well?

[Johannes Dollinger]

This would be fixed by the refactoring proposed in #7806 (which used akaihola's patch as a starting point, although not much is left).

[David Avsajanishvili]

A very little improvement of 5756.2.patch: changed line 182 in loader_tags.py (see #8088)

[Malcolm Tredinnick]

(In [10119]) Fixed #5756, #6296 -- Most template tags can now handle filters in arguments.

Most of the hard work for this was done by akaihola.

There are still possibly some problems with the i18n template tags,
since they are written quite differently and a few other bug fixes have
to made before they can be fixed.