Django

Code

Ticket #5720 (closed: fixed)

Opened 11 months ago

Last modified 11 months ago

[newforms-admin] - remove legacy Manipulator code

Reported by: brosner Assigned to: nobody
Milestone: Component: Admin interface
Version: newforms-admin Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation:
Needs tests: Patch needs improvement:

Description

I ran across a problem with having about 10,000 rows in a foreign key table and was using newforms-admin. I tracked it down to some legacy code that wanted to do something dumb and the reason for newforms in the first place. Per the discussion at http://groups.google.com/group/django-users/browse_frm/thread/a0a00061c0331107, I am creating this ticket and posting a patch to move render_change_form out of django.contrib.admin.views.main and into the ModelAdmin class. This also get rid of the dependancy of the ChangeManipulator and AddManipulator in newforms-admin.

Attachments

5720_newforms_admin_legacy_code_removal.diff (5.4 kB) - added by brosner on 10/09/07 18:10:34.

Change History

10/09/07 18:10:34 changed by brosner

  • attachment 5720_newforms_admin_legacy_code_removal.diff added.

10/09/07 21:48:26 changed by jkocherhans

  • status changed from new to closed.
  • resolution set to fixed.

(In [6470]) newforms-admin: Fixed #5720. render_change_form now belongs to ModelAdmin? and no longer uses manipulators. Thanks Brian Rosner.

Add/Change #5720 ([newforms-admin] - remove legacy Manipulator code)




Change Properties
Action