Opened 18 years ago
Closed 18 years ago
#5720 closed (fixed)
[newforms-admin] - remove legacy Manipulator code
| Reported by: | Brian Rosner | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I ran across a problem with having about 10,000 rows in a foreign key table and was using newforms-admin. I tracked it down to some legacy code that wanted to do something dumb and the reason for newforms in the first place. Per the discussion at http://groups.google.com/group/django-users/browse_frm/thread/a0a00061c0331107, I am creating this ticket and posting a patch to move render_change_form out of django.contrib.admin.views.main and into the ModelAdmin class. This also get rid of the dependancy of the ChangeManipulator and AddManipulator in newforms-admin.
Attachments (1)
Change History (2)
by , 18 years ago
| Attachment: | 5720_newforms_admin_legacy_code_removal.diff added |
|---|
comment:1 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
(In [6470]) newforms-admin: Fixed #5720. render_change_form now belongs to ModelAdmin and no longer uses manipulators. Thanks Brian Rosner.