Opened 17 years ago

Closed 14 years ago

Last modified 13 years ago

#5672 closed (fixed)

i18n minor problem (comma list items separator can't be translated) in django.utils.text.get_text_list()

Reported by: Reza Mohammadi Owned by: nobody
Component: Internationalization Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The string ', ' is not translatable in the source code. (django/utils/text.py:142)

In some countries arabic comma (،) is used:
Unicode 0600 block, Arabic comma is 060C.

Attachments (2)

list_separator_translatable.diff (1.1 KB ) - added by Claude Paroz 14 years ago.
Make list separator translatable
list_separator_translatable-2.diff (3.0 KB ) - added by Claude Paroz 14 years ago.
Patch including tests

Download all attachments as: .zip

Change History (14)

comment:1 by Simon G <dev@…>, 17 years ago

Triage Stage: UnreviewedDesign decision needed

comment:2 by Marc Garcia, 15 years ago

Keywords: i18n-nofix added

comment:3 by Ramiro Morales, 15 years ago

Summary: i18n minor problem in django.utils.text.get_text_list()i18n minor problem (comma list items separator can't be translated) in django.utils.text.get_text_list()

comment:4 by Alex Gaynor, 14 years ago

Triage Stage: Design decision neededAccepted

by Claude Paroz, 14 years ago

Make list separator translatable

comment:5 by Claude Paroz, 14 years ago

Has patch: set
Keywords: i18n-nofix removed

comment:6 by Jannis Leidel, 14 years ago

milestone: 1.3
Needs tests: set

by Claude Paroz, 14 years ago

Patch including tests

comment:7 by Claude Paroz, 14 years ago

I added a test, but as I don't speak arabic, it probably doesn't make much sense for a native speaker. However, it should be technically correct.

comment:8 by Jannis Leidel, 14 years ago

Triage Stage: AcceptedReady for checkin

comment:9 by Jannis Leidel, 14 years ago

Needs tests: unset

comment:10 by Alex Gaynor, 14 years ago

Fixed in [14876].

comment:11 by Alex Gaynor, 14 years ago

Resolution: fixed
Status: newclosed

comment:12 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top