Django

Code

Ticket #5628 (closed: fixed)

Opened 1 year ago

Last modified 5 months ago

[newforms-admin] - when an inline formset has errors, no message is displayed at the top of the form

Reported by: brosner Assigned to: jkocherhans
Milestone: 1.0 alpha Component: django.contrib.admin
Version: newforms-admin Keywords: nfa-blocker
Cc: framos@yaco.es Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

If an inline formset has any validation errors then the error message Please correct the errors below. won't be displayed at the top of the form.

Attachments

5628_formset_errors_fix.diff (3.2 kB) - added by brosner on 10/26/07 19:26:58.
00-admin-errors (2.2 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 11/20/07 21:50:06.
00-admin-errors.diff (2.2 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 11/20/07 21:51:55.
version with correct suffix

Change History

09/29/07 11:27:30 changed by jkocherhans

  • status changed from new to assigned.
  • needs_better_patch changed.
  • needs_tests changed.
  • owner changed from nobody to jkocherhans.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

10/26/07 19:26:58 changed by brosner

  • attachment 5628_formset_errors_fix.diff added.

10/26/07 19:29:12 changed by brosner

I have attached a patch that I am using to solve this problem. Not the best patch, some cleanup work is needed, but nonetheless it works. My apolozigies if anything is wrong with the patch since I am still trying to improve my life with SVK slowly, but surely ;)

11/20/07 21:50:06 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment 00-admin-errors added.

11/20/07 21:51:55 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment 00-admin-errors.diff added.

version with correct suffix

11/20/07 21:52:52 changed by Petr Marhoun <petr.marhoun@gmail.com>

Another version of patch - I think it is necessary to count all errors. So it can be chosen if "Please correct the error below." or "Please correct the errors below." should be used.

12/07/07 20:16:51 changed by brosner

  • keywords set to nfa-blocker.

Ah, much better patch than mine with the hacked up code ;) Marking as nfa-blocker.

01/02/08 12:44:41 changed by Alex

  • has_patch set to 1.

05/13/08 10:42:06 changed by framos

  • cc set to framos@yaco.es.

06/16/08 10:46:47 changed by garcia_marc

  • milestone set to 1.0 alpha.

07/10/08 15:32:06 changed by Alex

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in r7878

Add/Change #5628 ([newforms-admin] - when an inline formset has errors, no message is displayed at the top of the form)




Change Properties
Action