Signals for login / logout

I believe the contrib modules are supposed to be self-contained, so should the signal objects should probably be within contrib.auth rather than core.

Self contained (moved signals to contrib.auth.signals)

Marking as wont fix. Signal dispatching is slow. This should be accomplished using the daily_cleanup.py found in django/bin. If that doesn't suit you then rewrite parts of django.contrib.auth or maybe through a custom auth backend. Please reopen with better use cases. I just don't see signals being a solution to really any use case for something like this.

Signals are slow, but login and logout events would occur so rarely that signal performance shouldn't be a consideration here.

Another use case could be to log all login/outs in a single place (iso /admin/, /accounts/registration and possibly other locations or rewriting bits of django core). To alleviate the worries about speed, it could be made entirely optional and off by default.

Alright, I am going to re-open this ticket to get some exposure by the core devs. There are a few use cases for this and having an optional on and off switch would be nice to alleviate any performance issues.

Updated patch to work with newer version, changed behavior to trigger login signal before updating last_login because i need to log time between logins.

another use case: demo users - profiles, passwords and other data needs to be reset on login/logout.

I'd love to see this one - we'd like to hook into the login process and are considering wrapping the default views. What's the status on this one?

New patch with docs & tests. Also moved the update for last_login to a signal which allows for it to be disconnected if someone wanted to.

Another use case: with signal you could add a message to the user informing her that she was successfully logged in or out and redirect her to the page she wanted to go in the first place and not to the default login page. It is a nice information to users that they know what is happening behind the scenes.

I'd love to see this as in my app I'm currently wrapping the default login view to store login attempts. So preferably a hook for a successful login and another for a failed attempt.

I tried using a custom authentication back end to handle failed login attempts but those only get username/password - need the http request to dig out IP...

mitar: using signals doesn't just make that possible. In fact, it confuses the issue more: what if you have two conflicting responses from signal listeners?

drizzo4shizzo: that's an interesting idea - I don't think it's part of this primary ticket though so perhaps you should open a new ticket for that (and crosslink it to here)

I do not understand why it would not be possible. I am quite happily using such views:

def login(request, *args, **kwargs):
  res = login_view(request, *args, **kwargs)
  if request.user.is_authenticated():
    signals.user_login.send(sender=login, request=request, user=request.user)
  return res

def logout(request, *args, **kwargs):
  user = request.user
  res = logout_view(request, *args, **kwargs)
  signals.user_logout.send(sender=logout_redirect, request=request, user=user)
  return res

And then:

def user_login_message(request, user, **kwargs):
  messages.success(request, _("You have successfully logged in."), fail_silently=True)
user_login.connect(user_login_message)

def user_logout_message(request, user, **kwargs):
  messages.success(request, _("You have successfully logged out."), fail_silently=True)
user_logout.connect(user_logout_message)

Right, I get that adding a message would be a useful use of the signal.

It's was the "redirect her to the page she wanted to go in the first place and not the default login page" statement that I was referring to. It has nothing to do with signal listeners, which is what this ticket was about ;)

Ah, yes. This is something else. I pass next parameter to login view so that user is redirected back to where it started the login process. So I do not use signals for redirecting. But once you do redirecting it is nice to tell user that login was successful, because otherwise just some small part of the page changes (like that username is written somewhere instead of "login" link). So messages are useful to tell the user this. And having signals then makes this really easy to do.