Django

Code

Ticket #5604 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Access over HTTPS broken when using WSGI

Reported by: ramiro Assigned to: nobody
Milestone: Component: HTTP handling
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The WSGI handler relies on the presence of the 'HTTPS' environment var to detect the use of HTTPS.

WSGI spec dictates a server-side implementation MUST export a 'wsgi.url_scheme' var and SHOULD export a 'HTTPS' var.

Fix is a one-line patch.

discussed on:

http://groups.google.com/group/django-developers/browse_frm/thread/5af492b48fee4ff0?hl=en http://groups.google.com/group/modwsgi/browse_frm/thread/9cb69065a92e8f29?hl=en

Attachments

wsgi_https.diff (0.6 kB) - added by ramiro on 09/25/07 20:19:26.

Change History

09/25/07 20:19:26 changed by ramiro

  • attachment wsgi_https.diff added.

09/25/07 20:19:52 changed by ramiro

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

09/26/07 03:30:19 changed by SmileyChris

  • stage changed from Unreviewed to Ready for checkin.

Yep, it's good.

09/27/07 11:57:57 changed by gwilson

  • status changed from new to closed.
  • resolution set to fixed.

(In [6428]) Fixed #5604 -- Check for use of HTTPS by looking at the wsgi.url_scheme environment variable instead of the HTTPS environment variable since wsgi.url_scheme is required by the WSGI spec, while HTTPS is not. Thanks, ramiro.

Add/Change #5604 (Access over HTTPS broken when using WSGI)




Change Properties
Action