Opened 18 years ago

Closed 18 years ago

#5604 closed (fixed)

Access over HTTPS broken when using WSGI

Reported by: Ramiro Morales Owned by: nobody
Component: HTTP handling Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The WSGI handler relies on the presence of the 'HTTPS' environment var to detect the use of HTTPS.

WSGI spec dictates a server-side implementation MUST export a 'wsgi.url_scheme' var and SHOULD
export a 'HTTPS' var.

Fix is a one-line patch.

discussed on:

​http://groups.google.com/group/django-developers/browse_frm/thread/5af492b48fee4ff0?hl=en
​http://groups.google.com/group/modwsgi/browse_frm/thread/9cb69065a92e8f29?hl=en

Attachments (1)

wsgi_https.diff​ (655 bytes ) - added by Ramiro Morales 18 years ago.

Download all attachments as: .zip

Change History (4)

by Ramiro Morales, 18 years ago

Attachment: wsgi_https.diff​ added

comment:1 by Ramiro Morales, 18 years ago

Has patch: set

comment:2 by Chris Beaven, 18 years ago

Triage Stage: Unreviewed → Ready for checkin

Yep, it's good.

comment:3 by Gary Wilson, 18 years ago

Resolution: → fixed
Status: new → closed

(In [6428]) Fixed #5604 -- Check for use of HTTPS by looking at the wsgi.url_scheme environment variable instead of the HTTPS environment variable since wsgi.url_scheme is required by the WSGI spec, while HTTPS is not. Thanks, ramiro.

Note: See TracTickets for help on using tickets.
Back to Top