Django

Code

Ticket #5595 (closed: fixed)

Opened 9 months ago

Last modified 4 months ago

ModPythonRequest __repr__ is attempting to return a unicode object

Reported by: gwilson Assigned to: nobody
Milestone: Component: Core framework
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

And this is causing the repr of a ModPythonRequest? object to have backslashes escaped, which is causing newlines not to be interpreted (noticed in my server errors coming to me via email).

Attachments

5595.diff (2.7 kB) - added by gwilson on 09/25/07 00:13:28.
made use of smart_str in ModPythonRequest? repr

Change History

09/25/07 00:13:28 changed by gwilson

  • attachment 5595.diff added.

made use of smart_str in ModPythonRequest? repr

09/25/07 00:15:04 changed by gwilson

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

I do need the unicode() calls for python2.3 compatibility, right?

02/28/08 11:05:20 changed by jacob

  • stage changed from Unreviewed to Ready for checkin.

Gary, if these tests pass feel free to check this in; looks fine to me. IIRC you're right about needing the unicode() calls but it doesn't hurt if they're extraneous.

03/07/08 21:06:30 changed by gwilson

  • status changed from new to closed.
  • resolution set to fixed.

(In [7200]) Fixed #5595 -- Made ModPythonRequest.__repr__ return a string instead of a unicode object. Fixes the printout of the request object in those server error e-mails I never get :)

Add/Change #5595 (ModPythonRequest __repr__ is attempting to return a unicode object)




Change Properties
Action