Opened 17 years ago

Closed 17 years ago

#5595 closed (fixed)

ModPythonRequest __repr__ is attempting to return a unicode object

Reported by: Gary Wilson Owned by: nobody
Component: Core (Other) Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

And this is causing the repr of a ModPythonRequest object to have backslashes escaped, which is causing newlines not to be interpreted (noticed in my server errors coming to me via email).

Change History (4)

by Gary Wilson, 17 years ago

Attachment: 5595.diff​ added

made use of smart_str in ModPythonRequest repr

comment:1 by Gary Wilson, 17 years ago

Has patch: set

I do need the unicode() calls for python2.3 compatibility, right?

comment:2 by Jacob, 17 years ago

Triage Stage: Unreviewed → Ready for checkin

Gary, if these tests pass feel free to check this in; looks fine to me. IIRC you're right about needing the unicode() calls but it doesn't hurt if they're extraneous.

comment:3 by Gary Wilson, 17 years ago

Resolution: → fixed
Status: new → closed

(In [7200]) Fixed #5595 -- Made ModPythonRequest.__repr__ return a string instead of a unicode object. Fixes the printout of the request object in those server error e-mails I never get :)

Note: See TracTickets for help on using tickets.
Back to Top