Django

Code

Ticket #5574 (closed: fixed)

Opened 1 year ago

Last modified 7 months ago

FileField not properly serializing to XML

Reported by: Chris Henderson <chris@frogandtoadsoftware.com> Assigned to: prairiedogg
Milestone: Component: Serialization
Version: SVN Keywords: FileField, xml, serialization
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

When executing python manage.py dumpdata --format xml, FileField? fields get serialized using the get_FIELD_url() method, which is causing (for me at least) this error: 

Problem installing fixture 'myfixture.xml': [Errno 2] No such file or directory: u'/site_media/avatars/system/001.gif

The small attached patch fixes this problem by not treating FileField? fields differently than other fields.

Attachments

base_serializer.diff (0.6 kB) - added by Chris Henderson <chris@frogandtoadsoftware.com> on 09/22/07 02:53:01.

Change History

09/22/07 02:53:01 changed by Chris Henderson <chris@frogandtoadsoftware.com>

  • attachment base_serializer.diff added.

09/22/07 07:31:15 changed by russellm

  • status changed from new to closed.
  • needs_better_patch changed.
  • resolution set to worksforme.
  • needs_tests changed.
  • needs_docs changed.

I can't reproduce the problem you describe. Furthermore, the serializers regressiontest includes cases that serialize FileFields? with no actual file present.

If you can provide a sample model, fixture, and test procedure, feel free to reopen this ticket.

09/22/07 15:43:05 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

The issue isn't on serializing, but on trying to reload the info.

The serializer code calls get_fieldname_url instead of just outputting the database value: 

        elif isinstance(field, models.FileField):
            value = getattr(obj, "get_%s_url" % field.name, lambda: None)()

So when you read it back in, it's got the wrong value - in his example, while the field originally held "avatars/system/001.gif", the serializers output "/site_media/avatars/system/001.gif"

09/22/07 16:01:08 changed by cgrady

Er, the issue seems to only show up in the XML serializer, now that I look (that last comment was me btw)

09/22/07 20:35:06 changed by Chris Henderson <chris@frogandtoadsoftware.com>

The "no such file or directory" error I was getting and was noted in the report was actually related to a method being called from a pre_save signal being sent to resize an image, but the underlying problem does seem to be that the value in the database is changed as cgrady noted above. Sorry for the confusing report, but I do think that there is an actual problem in the XML serializer (which is calling the base serializer for this behavior).

12/11/07 12:06:41 changed by Gulopine

  • keywords changed from FileField, xml, serialization to FileField, xml, serialization, fs-rf.

12/17/07 21:01:59 changed by Gulopine

  • keywords changed from FileField, xml, serialization, fs-rf to FileField, xml, serialization.

After further research, I think this ticket is best dealt with as part of serialization, rather than in #5361.

02/28/08 11:00:56 changed by jacob

  • stage changed from Unreviewed to Accepted.

03/17/08 17:37:36 changed by prairiedogg

  • owner changed from nobody to prairiedogg.
  • status changed from reopened to new.
  • stage changed from Accepted to Ready for checkin.

Jacob Kaplan-Moss said that this was OK to check in even though it does not have a test. I confirmed that running this patch against the full django test suite did not produce errors, and also that it fixed the bug in my production case.

03/18/08 09:35:05 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7293]) Fixed #5574 -- Serialize a FileField? using its filename from the database, not external URL. The problem showed up when reloading the data. Patch from Chris Henderson.

Add/Change #5574 (FileField not properly serializing to XML)




Change Properties
Action