Django

Code

Ticket #5546 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Split newforms tests

Reported by: leosoto <leo.soto@gmail.com> Assigned to: nobody
Milestone: Component: Forms
Version: SVN Keywords: jython
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

tests/regressiontests/forms/{tests.py,localflavor.py} are too big for Jython, where exists a limit of 32KB for the length of string literals.

And, IMO, they are too big for humans too.

Attachments

Change History

09/19/07 18:22:33 changed by leosoto <leo.soto@gmail.com>

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

[The patch size is more than 256KBytes, so trac don't let me attach it here.]

http://www.leosoto.com/split_newforms_tests2.patch splits localflavors tests into its own directory (one file per flavor) and form tests into four files: widgets, fields, forms and extras.

As widgets.py and forms.py strings were still above 32KBytes, and I didn't knew a good criteria to split them more, string concatenation was used to avoid problems with Jython.

09/19/07 18:40:48 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [6379]) Fixed #5546: split form unit tests into manageable chunks. This isn't a perfect fix since the chunks aren't yet autodiscovered, but that shouldn't prevent checking this in. Thanks, Leo Soto.

Add/Change #5546 (Split newforms tests)




Change Properties
Action