Opened 17 years ago
Last modified 14 years ago
#5500 closed
Add an adminindex templatetag — at Version 13
| Reported by: | jkocherhans | Owned by: | Jannis Leidel |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | sprintdec01 edit inline add | |
| Cc: | Triage Stage: | Design decision needed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
The adminindex command [removed in r8548 --JKM] can only act on one site. Replacing its functionality with a templatetag, or possibly just an include would be a more robust solution.
Change History (14)
comment:1 by , 17 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 17 years ago
| Owner: | changed from to |
|---|
by , 17 years ago
| Attachment: | adminindex.diff added |
|---|
comment:3 by , 17 years ago
| Has patch: | set |
|---|
comment:4 by , 17 years ago
| Keywords: | sprintdec01 added |
|---|
comment:5 by , 17 years ago
| Keywords: | nfa-someday edit inline add added |
|---|
This isn't critical to the merge of newforms-admin. Tagging with nfa-someday. This looks reasonable and should eventually be fixed, but lets not get it in our way of merging newforms-admin.
comment:7 by , 17 years ago
No, this isn't a blocking task that has to be done before merging to trunk with newforms-admin. The ticket has been accepted and I think should get included. If there is time before merging then it should be looked at again.
comment:9 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
| Triage Stage: | Accepted → Fixed on a branch |
comment:10 by , 16 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Has this patch been applied? Searching by the ticket number does not return any changeset and neither trunk nor newforms-admin branch have it.
comment:11 by , 16 years ago
| Keywords: | nfa-someday removed |
|---|---|
| milestone: | → 1.0 |
| Patch needs improvement: | set |
| Triage Stage: | Fixed on a branch → Accepted |
| Version: | newforms-admin → SVN |
No, this patch hasn't been applied and the admin-index command hasn't been updated for newforms-admin. Given django.contrib.admin.site.index() I would also say it should use the functionality there to print those templates.
I talked to jkocherhans and brosner briefly on IRC and they said it should be looked at, hence marking it as 1.0.
comment:12 by , 16 years ago
comment:13 by , 16 years ago
| Description: | modified (diff) |
|---|---|
| milestone: | 1.0 → post-1.0 |
| Summary: | Replace the adminindex command with a suitable templatetag → Add an adminindex templatetag |
| Triage Stage: | Accepted → Design decision needed |
I've pushing this back down to DDN for the question of weather a template tag is needed at all; it's post-1.0 either way.
Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex