Django

Code

Ticket #5500 (reopened)

Opened 3 years ago

Last modified 1 year ago

Add an adminindex templatetag

Reported by: jkocherhans Assigned to: jezdez
Milestone: Component: django.contrib.admin
Version: SVN Keywords: sprintdec01 edit inline add
Cc: Triage Stage: Design decision needed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 1

Description (Last modified by jacob)

The adminindex command [removed in r8548 --JKM] can only act on one site. Replacing its functionality with a templatetag, or possibly just an include would be a more robust solution.

Attachments

adminindex.diff (4.7 kB) - added by jezdez on 12/01/07 09:53:38.
Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex

Change History

09/15/07 15:12:50 changed by jkocherhans

  • needs_better_patch changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs changed.

12/01/07 06:09:08 changed by jezdez

  • owner changed from nobody to jezdez.

12/01/07 09:53:38 changed by jezdez

  • attachment adminindex.diff added.

Implemented template tag admin_index in django.contrib.admin.templatetags.admin_list which is now also used by django.core.management.commands.adminindex

12/01/07 09:54:24 changed by jezdez

  • has_patch set to 1.

12/01/07 10:53:11 changed by jezdez

  • keywords set to sprintdec01.

12/10/07 11:30:11 changed by brosner

  • keywords changed from sprintdec01 to nfa-someday sprintdec01 edit inline add.

This isn't critical to the merge of newforms-admin. Tagging with nfa-someday. This looks reasonable and should eventually be fixed, but lets not get it in our way of merging newforms-admin.

12/10/07 11:32:18 changed by jezdez

In other words: it won't be fixed. right?

12/10/07 11:38:42 changed by brosner

No, this isn't a blocking task that has to be done before merging to trunk with newforms-admin. The ticket has been accepted and I think should get included. If there is time before merging then it should be looked at again.

12/10/07 11:40:12 changed by jezdez

Ok, this sounds reasonable. Thanks for clarification!

06/16/08 12:41:40 changed by jezdez

  • status changed from new to closed.
  • resolution set to fixed.
  • stage changed from Accepted to Fixed on a branch.

08/19/08 12:20:02 changed by emes

  • status changed from closed to reopened.
  • resolution deleted.

Has this patch been applied? Searching by the ticket number does not return any changeset and neither trunk nor newforms-admin branch have it.

08/19/08 16:17:01 changed by jezdez

  • keywords changed from nfa-someday sprintdec01 edit inline add to sprintdec01 edit inline add.
  • needs_better_patch set to 1.
  • stage changed from Fixed on a branch to Accepted.
  • version changed from newforms-admin to SVN.
  • milestone set to 1.0.

No, this patch hasn't been applied and the admin-index command hasn't been updated for newforms-admin. Given django.contrib.admin.site.index() I would also say it should use the functionality there to print those templates.

I talked to jkocherhans and brosner briefly on IRC and they said it should be looked at, hence marking it as 1.0.

08/25/08 13:53:19 changed by jacob

(In [8548]) Removed outdated "adminindex" command -- the same behavior is now far easier and better done in a template, or perhaps a custom AdminSite.index function. Refs #5500.

08/25/08 14:06:07 changed by jacob

  • stage changed from Accepted to Design decision needed.
  • summary changed from Replace the adminindex command with a suitable templatetag to Add an adminindex templatetag.
  • description changed.
  • milestone changed from 1.0 to post-1.0.

I've pushing this back down to DDN for the question of weather a template tag is needed at all; it's post-1.0 either way.

02/25/09 13:51:44 changed by

  • milestone deleted.

Milestone post-1.0 deleted

Add/Change #5500 (Add an adminindex templatetag)




Change Properties
Action