Django

Code

Ticket #5491 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Make make-messages.py sort filenames when processing files

Reported by: ramiro Assigned to: nobody
Milestone: Component: Internationalization
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

When make-messages.py enumerates the files it will extract translatable strings from, filesystem enumeration peculiarities cause changes in the layout of th final .po file being created/updated. In the case of the Django translations this difficult reviewing and makes translator-submitted patches bigger than should be.

The patch just makes it .sort() the list of files to process before.

Attachments

make_mess_file_sort.diff (0.8 kB) - added by ramiro on 09/15/07 07:30:01.

Change History

09/15/07 07:30:01 changed by ramiro

  • attachment make_mess_file_sort.diff added.

09/15/07 22:48:43 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

10/02/07 20:41:04 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6445]) Fixed #5491 -- Changed PO file generation to sort the filenames we scan prior to passing them to gettext. This should help reduce the changes in line orderings caused by different translators using different operating systems and locales. Based on a patch from Ramiro Morales.

Add/Change #5491 (Make make-messages.py sort filenames when processing files)




Change Properties
Action