Django

Code

Ticket #5431 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Argentinean localflavor

Reported by: ramiro Assigned to: nobody
Milestone: Component: django.contrib.localflavor
Version: SVN Keywords: aArgentina localflavor
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Find attached the patch that implemements a widget and some field for Argentina-specific information, it included test cases.

Note: I can't get Mercurial to represent the empty django/contrib/localflavor/ar/__init__.py file on the patch it generates, so if this get commited, the file should be created manually, sorry for the burden :(

Attachments

argentinean_localflavor_r6139.diff (14.9 kB) - added by ramiro on 09/13/07 17:50:23.
argentinean_localflavor_r6139-2.diff (14.9 kB) - added by ramiro on 09/13/07 19:14:44.

Change History

09/13/07 17:50:23 changed by ramiro

  • attachment argentinean_localflavor_r6139.diff added.

09/13/07 17:51:54 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

(follow-up: ↓ 3 ) 09/13/07 18:51:13 changed by mtredinnick

Line 112 of the patch can't be correct. It's referencing a variable that doesn't exist. Do you mean cuit[:-1] there?

(in reply to: ↑ 2 ) 09/13/07 19:11:33 changed by ramiro

  • keywords changed from argentina localflavor to aArgentina localflavor.

Replying to mtredinnick:

Line 112 of the patch can't be correct. It's referencing a variable that doesn't exist. Do you mean cuit[:-1] there?

You are completely right, sorry. New version of the patch attached with that fix.

/me installs pychecker.

09/13/07 19:14:44 changed by ramiro

  • attachment argentinean_localflavor_r6139-2.diff added.

09/13/07 19:58:58 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6145]) Fixed #5431 -- Added Argentinean localflavor. Thanks, Ramiro Morales.

Add/Change #5431 (Argentinean localflavor)




Change Properties
Action