Opened 18 years ago

Closed 18 years ago

#5394 closed (fixed)

REDIRECT_FIELD_NAME should be configurable

Reported by: Petr Marhoun <petr.marhoun@…> Owned by: David Reynolds
Component: Contrib apps Version: dev
Severity: Keywords: authorization, redirection, sprintsept14
Cc: david@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I think that it should be possible to set REDIRECT_FIELD_NAME in settings.py. For example it can be useful if I want to have url in another language than English. It is changed by the attached patch.

Attachments (5)

configurable-redirect-field-name.diff​ (3.8 KB ) - added by Petr Marhoun <petr.marhoun@…> 18 years ago.
configurable-redirect-field-name-2.diff​ (3.5 KB ) - added by David Reynolds 18 years ago.
Fixing as per Adrian's suggestion
5394-docs.diff​ (721 bytes ) - added by Antti Kaihola 18 years ago.
documentation for the patch
authentication-docs.diff​ (1.3 KB ) - added by David Reynolds 18 years ago.
update authentication docs
redirect_to_fieldaddition.diff​ (7.8 KB ) - added by David Reynolds 18 years ago.
All encompassing patch

Download all attachments as: .zip

Change History (15)

by Petr Marhoun <petr.marhoun@…>, 18 years ago

Attachment: configurable-redirect-field-name.diff​ added

comment:1 by Simon G. <dev@…>, 18 years ago

Triage Stage: Unreviewed → Design decision needed

comment:2 by Adrian Holovaty, 18 years ago

Needs documentation: set
Patch needs improvement: set
Triage Stage: Design decision needed → Accepted

I agree that it should be configurable, but this is not "heavy" enough to merit a new setting. Instead, how about making the relevant auth views and decorators accept an optional redirect_field argument? Marking as "patch needs improvement" for that reason.

comment:3 by David Reynolds, 18 years ago

Owner: changed from nobody to David Reynolds

by David Reynolds, 18 years ago

Attachment: configurable-redirect-field-name-2.diff​ added

Fixing as per Adrian's suggestion

comment:4 by David Reynolds, 18 years ago

Patch needs improvement: unset

comment:5 by Antti Kaihola, 18 years ago

Can this now be removed from SprintIdeas?

by Antti Kaihola, 18 years ago

Attachment: 5394-docs.diff​ added

documentation for the patch

comment:6 by David Reynolds, 18 years ago

Cc: david@… added

This change to the docs only reflects the original, bad patch, not my updated patch.

I'll look at the doing the docs now.

by David Reynolds, 18 years ago

Attachment: authentication-docs.diff​ added

update authentication docs

comment:7 by David Reynolds, 18 years ago

Needs documentation: unset

by David Reynolds, 18 years ago

Attachment: redirect_to_fieldaddition.diff​ added

All encompassing patch

comment:8 by David Reynolds, 18 years ago

Resolution: → fixed
Status: new → closed

(forgot to mention effbot on irc helped massively with last patch)

comment:9 by David Reynolds, 18 years ago

Keywords: sprintsept14 added
Resolution: fixed
Status: closed → reopened

comment:10 by Adrian Holovaty, 18 years ago

Resolution: → fixed
Status: reopened → closed

(In [6206]) Fixed #5394 -- REDIRECT_FIELD_NAME is now configurable. Thanks, Petr Marhoun, DavidReynolds and effbot

Note: See TracTickets for help on using tickets.
Back to Top