Django

Code

Ticket #5394 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

REDIRECT_FIELD_NAME should be configurable

Reported by: Petr Marhoun <petr.marhoun@gmail.com> Assigned to: DavidReynolds
Milestone: Component: Contrib apps
Version: SVN Keywords: authorization, redirection, sprintsept14
Cc: david@reynoldsfamily.org.uk Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I think that it should be possible to set REDIRECT_FIELD_NAME in settings.py. For example it can be useful if I want to have url in another language than English. It is changed by the attached patch.

Attachments

configurable-redirect-field-name.diff (3.8 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 09/10/07 13:07:07.
configurable-redirect-field-name-2.diff (3.5 kB) - added by DavidReynolds on 09/14/07 06:36:13.
Fixing as per Adrian's suggestion
5394-docs.diff (0.7 kB) - added by akaihola on 09/14/07 08:28:09.
documentation for the patch
authentication-docs.diff (1.3 kB) - added by DavidReynolds on 09/14/07 08:56:06.
update authentication docs
redirect_to_fieldaddition.diff (7.8 kB) - added by DavidReynolds on 09/14/07 11:19:14.
All encompassing patch

Change History

09/10/07 13:07:07 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment configurable-redirect-field-name.diff added.

09/10/07 21:37:21 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

09/13/07 23:42:55 changed by adrian

  • needs_better_patch set to 1.
  • stage changed from Design decision needed to Accepted.
  • needs_docs set to 1.

I agree that it should be configurable, but this is not "heavy" enough to merit a new setting. Instead, how about making the relevant auth views and decorators accept an optional redirect_field argument? Marking as "patch needs improvement" for that reason.

09/14/07 04:16:32 changed by DavidReynolds

  • owner changed from nobody to DavidReynolds.

09/14/07 06:36:13 changed by DavidReynolds

  • attachment configurable-redirect-field-name-2.diff added.

Fixing as per Adrian's suggestion

09/14/07 06:37:07 changed by DavidReynolds

  • needs_better_patch deleted.

09/14/07 08:18:31 changed by akaihola

Can this now be removed from SprintIdeas?

09/14/07 08:28:09 changed by akaihola

  • attachment 5394-docs.diff added.

documentation for the patch

09/14/07 08:38:15 changed by DavidReynolds

  • cc set to david@reynoldsfamily.org.uk.

This change to the docs only reflects the original, bad patch, not my updated patch.

I'll look at the doing the docs now.

09/14/07 08:56:06 changed by DavidReynolds

  • attachment authentication-docs.diff added.

update authentication docs

09/14/07 08:56:30 changed by DavidReynolds

  • needs_docs deleted.

09/14/07 11:19:14 changed by DavidReynolds

  • attachment redirect_to_fieldaddition.diff added.

All encompassing patch

09/14/07 11:26:52 changed by DavidReynolds

  • status changed from new to closed.
  • resolution set to fixed.

(forgot to mention effbot on irc helped massively with last patch)

09/14/07 11:27:42 changed by DavidReynolds

  • keywords changed from authorization, redirection to authorization, redirection, sprintsept14.
  • status changed from closed to reopened.
  • resolution deleted.

09/14/07 14:25:38 changed by adrian

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6206]) Fixed #5394 -- REDIRECT_FIELD_NAME is now configurable. Thanks, Petr Marhoun, DavidReynolds? and effbot

Add/Change #5394 (REDIRECT_FIELD_NAME should be configurable)




Change Properties
Action