Django

Code

Ticket #5383 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

[newforms-admin] - InlineModelAdmin.formset_class is used but not set.

Reported by: Petr Marhoun <petr.marhoun@gmail.com> Assigned to: jkocherhans
Milestone: Component: Admin interface
Version: newforms-admin Keywords: newforms, admin, inlines
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I think there is a little bug in [6080].

In InlineModelAdmin?._fieldsets (row 684) attribute formset_class is used. But it was removed from init in [6080].

Attached patch gives it back.

I am not sure if it is the right solution - maybe only fields should be saved. See also #5372 - I think that it isn't a good idea to use one formset_class for all requests.

Attachments

formset-class-not-set.diff (0.9 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 09/10/07 08:52:12.

Change History

09/10/07 08:52:12 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment formset-class-not-set.diff added.

09/10/07 21:40:34 changed by jkocherhans

  • status changed from new to assigned.
  • needs_better_patch changed.
  • needs_tests changed.
  • owner changed from nobody to jkocherhans.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

09/11/07 20:34:26 changed by jkocherhans

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6102]) newforms-admin: Fixed #5383.

Add/Change #5383 ([newforms-admin] - InlineModelAdmin.formset_class is used but not set.)




Change Properties
Action