Django

Code

Ticket #5362 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

markup test with docutils failed

Reported by: Dirk Datzert <dummy@habmalnefrage.de> Assigned to: keithb
Milestone: Component: Testing framework
Version: SVN Keywords:
Cc: kbussell@gmail.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Hi,

I have python 2.5, docutils 0.5 and SVN-trunk (Rev 6066) Django installed. I run the django/contrib/markup/tests.py and I wondered that the docutils test failed.

Attached a fix for the bug !?

Regards, Dirk

Attachments

django-contrib-markup-tests.patch (0.6 kB) - added by Dirk Datzert <dummy@habmalnefrage.de> on 09/08/07 05:51:29.
markup docutils test fix
5362_fix.diff (1.0 kB) - added by keithb on 12/01/07 21:35:09.
Patch for the test

Change History

09/08/07 05:51:29 changed by Dirk Datzert <dummy@habmalnefrage.de>

  • attachment django-contrib-markup-tests.patch added.

markup docutils test fix

09/13/07 06:33:58 changed by russellm

  • status changed from new to closed.
  • needs_better_patch changed.
  • resolution set to worksforme.
  • needs_tests changed.
  • needs_docs changed.

This works as-is for docutils-0.4. Where are you getting docutils 0.5 from? The project home page lists this 0.4 as the current release, and there is no 0.5 tarball available for download.

(follow-up: ↓ 4 ) 09/13/07 14:27:20 changed by Dirk Datzert <dummy@habmalnefrage.de>

There will no separate docutils 0.5 tarball. This is in the version released with python2.5

docutils.version

'0.5'

docutils.version_details

'snapshot 2007-09-07, r5427'

http://docutils.sourceforge.net/RELEASE-NOTES.html#release-0-4-2006-01-09 claims this:

Docutils 0.4.x is the last version that will support Python 2.1. Docutils 0.5 will not be compatible with Python 2.1; Python 2.2 or later will be required.

09/13/07 19:06:29 changed by russellm

  • status changed from closed to reopened.
  • resolution deleted.

Ah - ok. I'll need to break out a Python2.5 install.

(in reply to: ↑ 2 ) 09/21/07 00:38:06 changed by mboersma

Replying to Dirk Datzert <dummy@habmalnefrage.de>:

There will no separate docutils 0.5 tarball. This is in the version released with python2.5

There is no docutils 0.5 release, at last not as of today. And docutils is not a battery included with Python 2.5 or 2.5.1, sorry: http://docs.python.org/modindex.html

I don't think this is worth anyone spending time on.

12/01/07 21:34:23 changed by keithb

  • owner changed from nobody to keithb.
  • status changed from reopened to new.

I tested and verified this bug with python2.5.1, and the latest source snapshot of docutils. Note that this is the recommended distribution, and it installs itself as v0.5.

docutils v0.4 does not exhibit this problem.

I created a patch to take both versions into account.

12/01/07 21:35:09 changed by keithb

  • attachment 5362_fix.diff added.

Patch for the test

12/01/07 21:36:18 changed by keithb

  • cc set to kbussell@gmail.com.

12/01/07 21:36:53 changed by keithb

  • status changed from new to assigned.

12/01/07 21:49:05 changed by Simon G <dev@simon.net.nz>

  • stage changed from Unreviewed to Ready for checkin.

Excellent - thanks for tracking this down Keithb

12/02/07 15:01:17 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6850]) Fixed #5362: markup tests no longer fail under SVN versions of docutils. Thanks, keithb.

Add/Change #5362 (markup test with docutils failed)




Change Properties
Action