Django

Code

Ticket #5357 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Documentation should include page argument of object_list

Reported by: Brian Morton <rokclimb15@gmail.com> Assigned to: mitja
Milestone: Component: Documentation
Version: SVN Keywords: object_list, page, pagination, sprintsept14
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 1
Needs tests: 0 Patch needs improvement: 0

Description

Currently, the generic view documentation at http://www.djangoproject.com/documentation/generic_views/#django-views-generic-list-detail-object-list makes no mention of the page keyword argument, which is the current page being viewed. This is transparent if you are calling object_list from the urlconf, since the view receives this argument on its own. However, if you are writing a wrapper around object_list, it is important to know that it accepts the page argument since you must intercept it and pass it yourself. Otherwise the view will not function properly with pagination.

Attachments

generic_views_r6243.diff (0.8 kB) - added by mitja on 09/14/07 18:04:07.
Adds documentation for page argument against r6243

Change History

09/10/07 21:35:30 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs set to 1.

09/14/07 16:38:17 changed by flother

  • status changed from new to closed.
  • resolution set to duplicate.

Marked as duplicate as this was patched in #4330 and fixed in [5293].

09/14/07 16:40:46 changed by flother

  • status changed from closed to reopened.
  • resolution deleted.

Oops, that last comment was meant for #3757. Reopened.

09/14/07 16:55:41 changed by nickefford

  • owner changed from nobody to nickefford.
  • status changed from reopened to new.

09/14/07 17:14:05 changed by mitja

  • owner changed from nickefford to mitja.
  • status changed from new to assigned.

09/14/07 18:04:07 changed by mitja

  • attachment generic_views_r6243.diff added.

Adds documentation for page argument against r6243

09/14/07 18:06:46 changed by mitja

  • keywords changed from object_list, page, pagination to object_list, page, pagination, sprintsept14.
  • has_patch set to 1.

09/14/07 19:53:03 changed by ubernostrum

  • stage changed from Accepted to Ready for checkin.

Patch looks good to me.

09/15/07 06:19:35 changed by russellm

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6280]) Fixed #5357 -- Added documentation on the 'page' argument to generic object_list views. Thanks, mitja.

Add/Change #5357 (Documentation should include page argument of object_list)




Change Properties
Action