DecimalField may "clean" itself and then raise an Exception

[Weipin Xia <webbing@…>]

DecimalField may "clean" itself and then raise an Exception. In my case, it happens when I put a DecimalField in a django.newforms.Form class which will be used to "Edit" the model.

I suppose it would be necessary to check the type of parameter value like some of the other "Field" classes, such as DateField.

         super(DecimalField, self).clean(value)
         if not self.required and value in EMPTY_VALUES:
             return None
         value = value.strip() # raise AttributeError, 'Decimal' object has no attribute 'strip'
         try:
             value = Decimal(value)

[Philippe Raoult]

There's no reason value would already be a decimal unless the data was a decimal in the first place. If you use a form with string input this will never happen. Maybe we should check in form inputs that the values are really strings and/or enforce this ?

[Philippe Raoult]

correct patch with regression tests

[Malcolm Tredinnick]

So, for reference, there were a few problems with this patch.

• The first version didn't check the precision.
• The second version didn't work on input like " 3.14".
• The test in the second version showed that IntegerField was cleaning 3.14 (the number) to 3, rather than raising an error.

I'm committing something that fixes all of these.

[Malcolm Tredinnick]

(In [6282]) Fixed #5355 -- Fixed data cleaning for DecimalField.

In passing, fixed a problem with cleaning in IntegerField.

Includes tests from PhiR.

[Fredrik Lundh <fredrik@…>]

There were an extensive discussion last night (european time); I simply assumed that tests in the final patch matched what was agreed upon.