Django

Code

Ticket #5340 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

request for new link in docs

Reported by: rogerpack2005@gmail.com Assigned to: justinlilly@gmail.com
Milestone: Component: Documentation
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I think that http://www.djangoproject.com/documentation/templates/ should link to http://www.djangoproject.com/documentation/templates_python/ at the bottom--maybe a link like "click here to program your own" or what not. Thanks! Django rox!

Attachments

templates.txt (45.2 kB) - added by justinlilly@gmail.com on 09/14/07 03:17:27.
Proposed patch to fix the escaping issue causing the bug
template.diff (177 bytes) - added by Justin Lilly <justinlilly@gmail.com> on 09/14/07 04:25:32.
This should be the .diff file required.
template.2.diff (0.6 kB) - added by Justin Lilly <justinlilly@gmail.com> on 09/14/07 04:33:14.
This should be a viewable version of the previous patch.

Change History

09/09/07 12:18:36 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [6070]) Fixed #5340 -- Linked docs/templates.txt to docs/templates_python.txt

09/11/07 13:00:27 changed by john.scott.atlakson@gmail.com

  • status changed from closed to reopened.
  • needs_better_patch set to 1.
  • resolution deleted.
  • needs_tests changed.
  • needs_docs changed.

This patch results in an error...see http://www.djangoproject.com/documentation/templates/#id3 I don't know much about reStructured Text formatting but my guess that the colon within the link name might be confusing the parser. The line in question:

.. _The Django template language: For Python programmers: ../templates_python/

09/14/07 03:17:27 changed by justinlilly@gmail.com

  • attachment templates.txt added.

Proposed patch to fix the escaping issue causing the bug

09/14/07 03:22:15 changed by justinlilly@gmail.com

  • status changed from reopened to closed.
  • needs_better_patch deleted.
  • resolution set to fixed.
  • stage changed from Unreviewed to Ready for checkin.

Should be fixed. Just needed an escaping backslash on the link. I've tested this with http://www.hosting4u.cz/jbar/rest/rest.html which seemed to do okay.

09/14/07 03:38:13 changed by russellm

  • status changed from closed to reopened.
  • resolution deleted.
  • stage changed from Ready for checkin to Accepted.

This isn't ready for checkin - it needs to be submitted as a patch, not as a replacement file. Also, please don't mark the ticket as fixed - that is done automatically by SVN during the checkin process.

09/14/07 03:44:28 changed by justinlilly@gmail.com

  • owner changed from jacob to justinlilly@gmail.com.
  • status changed from reopened to new.
  • has_patch set to 1.

Terribly sorry for that. Well then, I suppose this is me submitting the item as "Has Patch", accepting it personally. Sorry, this is my first ticket so here goes again, eh?

09/14/07 03:57:08 changed by russellm

Perhaps I wasn't clear - the file you upload needs to be a patch - i.e., a diff file, not a complete replacement for the original.

09/14/07 04:25:32 changed by Justin Lilly <justinlilly@gmail.com>

  • attachment template.diff added.

This should be the .diff file required.

09/14/07 04:33:14 changed by Justin Lilly <justinlilly@gmail.com>

  • attachment template.2.diff added.

This should be a viewable version of the previous patch.

09/14/07 05:11:02 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6184]) Fixed #5340 -- Fixed a broken link. Thanks, Justin Lilly.

Add/Change #5340 (request for new link in docs)




Change Properties
Action