Django

Code

Ticket #5331 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

URLField should add http:// if no scheme given

Reported by: SmileyChris Assigned to: nobody
Milestone: Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The usual scheme for a URLField is http://. You're average user will often not enter the scheme of their URL so the clean method should just prepend 'http://' if no scheme was given.

Attachments

urlfield.patch (0.5 kB) - added by SmileyChris on 09/03/07 18:12:09.
urlfield.2.patch (1.7 kB) - added by SmileyChris on 09/03/07 18:25:46.
with tests

Change History

09/03/07 18:12:09 changed by SmileyChris

  • attachment urlfield.patch added.

09/03/07 18:12:42 changed by SmileyChris

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

Makes sense to me, but I'll pass it past the core developers.

09/03/07 18:25:46 changed by SmileyChris

  • attachment urlfield.2.patch added.

with tests

09/14/07 01:25:57 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Design decision needed to Ready for checkin.

Ready to go.

09/14/07 02:04:52 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [6173]) Fixed #5331 -- Modified newforms URLField to prepend http:// if no protocol is specified by the user. Thanks, SmileyChris??.

Add/Change #5331 (URLField should add http:// if no scheme given)




Change Properties
Action