Django

Code

Ticket #5251 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

[newforms-admin] "Show in Web" links not working

Reported by: Florian Apolloner Assigned to: apollo13
Milestone: Component: django.contrib.admin
Version: newforms-admin Keywords: newforms-admin reverse sprintsept14
Cc: django@apolloner.eu Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The "Show in Web" Links on the change pages of the django admin are not working as admin/r/10/1 (just an example) returns "app u'r', model 10 (or something like it ;)) not found"... This patch moves the checking to contrib/admin/sites to prevent this special url from getting displayed as model_page which obviously fails...

Attachments

show_in_web-6000.diff (1.5 kB) - added by Florian Apolloner on 08/24/07 14:22:41.
show_in_web.diff (0.7 kB) - added by apollo13 on 09/14/07 12:18:25.
Shorter and better patch :)

Change History

08/24/07 14:22:41 changed by Florian Apolloner

  • attachment show_in_web-6000.diff added.

08/29/07 07:58:31 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • summary changed from [newforms-admin][patch] "Show in Web" links not working to [newforms-admin] "Show in Web" links not working.
  • needs_tests changed.
  • needs_docs changed.

09/14/07 11:51:41 changed by jacob

  • needs_better_patch set to 1.
  • stage changed from Ready for checkin to Accepted.

The special-casing in this patch isn't right. I think it can be fixed just be reordering the admin urlconf instead of this weird dispatch thing.

09/14/07 12:18:25 changed by apollo13

  • attachment show_in_web.diff added.

Shorter and better patch :)

09/14/07 12:19:10 changed by apollo13

  • needs_better_patch deleted.

09/14/07 12:19:57 changed by apollo13

I don't think it can be moved, as admin.site.root tries to call model_page, but my new patch is better :)

09/14/07 12:23:10 changed by apollo13

  • owner changed from nobody to apollo13.
  • status changed from new to assigned.

09/14/07 14:07:20 changed by anonymous

  • keywords changed from newforms-admin reverse /admin/r/ to newforms-admin reverse sprintsept14.

09/14/07 14:28:16 changed by adrian

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6207]) newforms-admin: Fixed #5251 -- 'Show in Web' links now work properly again. Thanks, Florian Apolloner

Add/Change #5251 ([newforms-admin] "Show in Web" links not working)




Change Properties
Action