ModelMultipleChoiceField doesn't select initial choices

svn diff for patch application

Note also that in my SVN branch smart_unicode() is used; in my installed version force_unicode() is used instead. In my patch I use smart_unicode(); if it has gone away then simply replace it with force_unicode().

might be a duplicate of #5481 which also has a patch.

It's not a duplicate, but its semi-relevant. In #5481, whatever ends up as keys in ChoiceField?.choices gets faithfully returned as cleaned_data - be it integer, string, object, etc.

Should creating keys be the widgets responsibility or the fields?

patch against #6702 that passes tests

Just by looking at them, you can see the patches can't work. ModelMultipleChoiceField is defined as a function when it should be a class. In the latest patch, it is then imported into another model and never used!

To determine correctness, there should be a test which fails without the patch, and passes with it.

OK, here's a better patch, although I'm not sure it is the right one. It works for me but I'm not sure that testing for _get_pk_val is the best way to determine whether we're working with a model instance or not. Unfortunately, django.db.models can't be imported here to use isinstance

Here is a simple test case for the problem:

models.py:

from django.db import models

class MyModel(models.Model):
    name = models.CharField(max_length=100)

forms.py:

from django import newforms as forms
from myapp.models import MyModel

class MyForm(forms.Form):
    my_field = forms.ModelMultipleChoiceField(queryset=MyModel.objects.all())

from myapp import forms
from myapp.models import MyModel
MyModel.objects.create(name="one")
f = forms.MyForm({'my_field':MyModel.objects.all()})
f['my_field'].data #correct
f['my_field'].as_widget() #incorrect, without patch nothing is selected

better patch

I really don't think special casing objects is the right thing to do here (Especially a hacky type checking using hasattr). While what is described doesn't work, I feel this is a very uncommon use-case that can be easily fixed by simple using list comprehension:

>>> form = forms.MyForm(initial={"my_field": [o.pk for o in MyModel.objects.all()]})
>>> print form["my_field"]
<select multiple="multiple" name="my_field" id="id_my_field">
<option value="1" selected="selected">Test 1</option>
<option value="2" selected="selected">Test 2</option>
<option value="3" selected="selected">Test 3</option>
<option value="4" selected="selected">Test 4</option>

Jacob,

I meant to close this ticket as a wontfix, but looks like I forgot to do that, per my reasoning above. Do you see that the current patch something that is acceptable or another way to solve this? I feel a simple list comprehension above would be fine the correct way to solve this.

Ugh, ok, I thought about this a bit more on my way into work. I am completely missing the point ;) Discard what I said earlier. I am going to look into this a bit more.

Yeah, I would expect if I've got a ModelMultipleChoiceField I should be able to do initial={'f': MyModel.objects.filter(....)} and have that Just Work™.

I have the same problem with initial choice selected. I have applied the patch, and the problem is solved. Then, why this patch is not included in the trunk ?