Django

Code

Ticket #5161 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

mysql backend repeatedly adds warnings filter

Reported by: adurdin@gmail.com Assigned to: nobody
Milestone: Component: Uncategorized
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

See /trunk/django/db/backends/mysql/base.py, line 82 (r5609 at time of writing).

The mysql backend's cursor() method calls warnings.filterwarnings() each time a cursor is requested (if DEBUG==True). Instead, filterwarnings() should only be called once (e.g. at module load), to avoid needlessly adding identical filters to the warnings module's internal list.

Attachments

patch_5161.diff (1.0 kB) - added by durdinator on 09/14/07 16:56:27.

Change History

08/15/07 06:11:28 changed by mtredinnick

  • needs_better_patch changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs changed.

09/14/07 16:56:27 changed by durdinator

  • attachment patch_5161.diff added.

09/14/07 17:01:43 changed by durdinator

  • has_patch set to 1.

09/14/07 17:05:59 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [6229]) Fixed #5161 -- Changed MySQL backend only to report warning once. Thanks, durdinator

Add/Change #5161 (mysql backend repeatedly adds warnings filter)




Change Properties
Action