Django

Code

Ticket #5123 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

ImageField.formfield does not pass arguments correctly

Reported by: Collin Anderson <cmawebsite@gmail.com> Assigned to: nobody
Milestone: Component: Forms
Version: SVN Keywords: ImageField formfield
Cc: cmawebsite@gmail.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

formfield method of ImageField? database field does not pass arguments correctly. It replaces instead of updating.

Attachments

5833 ImageField formfield.patch (442 bytes) - added by Collin Anderson <cmawebsite@gmail.com> on 08/09/07 10:14:03.
This adds the missing line that is in the other formfield methods of most of the other fields.

Change History

08/09/07 10:14:03 changed by Collin Anderson <cmawebsite@gmail.com>

  • attachment 5833 ImageField formfield.patch added.

This adds the missing line that is in the other formfield methods of most of the other fields.

09/13/07 05:11:35 changed by Marco Bonetti <mbonetti@gmail.com>

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

I've had exactly the same problem as Collin (i.e. not being able to properly subclass ImageField? because formfield() doesn't add to defaults) and came up with exactly the same solution. I therefore think his patch should be accepted and merged in.

09/13/07 20:59:35 changed by SmileyChris

  • stage changed from Unreviewed to Ready for checkin.

09/13/07 21:54:12 changed by gwilson

  • status changed from new to closed.
  • resolution set to fixed.

(In [6154]) Fixed #5123 -- Fixed ImageField? to pass along keyword arguments in its formfield method.

Add/Change #5123 (ImageField.formfield does not pass arguments correctly)




Change Properties
Action