Django

Code

Ticket #5087 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Error filtering on TextField when using Oracle backend

Reported by: ian.g.kelly@gmail.com Assigned to: adrian
Milestone: Component: Database wrapper
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Filtering on a TextField? with the Oracle backend raises an error, because Oracle LOBs can't be compared directly inside a WHERE clause. This is especially problematic for the Admin interface, which uses a TextField? foreign key in the history table. See the comments in #4186 for an example of this, but I'm opening a new ticket because this patch doesn't address the original bug of that ticket.

Attachments

oracle_textfield_lookup.diff (5.1 kB) - added by ian.g.kelly@gmail.com on 08/04/07 18:02:45.
oracle_textfield_lookup.2.diff (5.4 kB) - added by ian.g.kelly@gmail.com on 08/06/07 12:33:39.
New version that doesn't break everything -- I should know better than to submit patches when I don't have a test environment available

Change History

08/04/07 18:02:45 changed by ian.g.kelly@gmail.com

  • attachment oracle_textfield_lookup.diff added.

08/06/07 12:33:39 changed by ian.g.kelly@gmail.com

  • attachment oracle_textfield_lookup.2.diff added.

New version that doesn't break everything -- I should know better than to submit patches when I don't have a test environment available

08/18/07 09:51:32 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

08/19/07 07:35:28 changed by mtredinnick

The patch looks reasonable and I've verified the tests pass on all the MySQL/PostgreSQL/SQLite backends. My vmware setup is hosed at the moment, so I can't test Oracle. Since that's your area anyway, Ian, I'm not too worried.

08/19/07 07:37:01 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5943]) Fixed #5087 -- Fixed support for TextField? filtering with Oracle. Thanks, Ian Kelly.

Add/Change #5087 (Error filtering on TextField when using Oracle backend)




Change Properties
Action