Django

Code

Ticket #5013 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Inaccurate middleware documentation for process_request and process_view

Reported by: tailofthesun@gmail.com Assigned to: nobody
Milestone: Component: Documentation
Version: SVN Keywords: process_request middleware
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The documentation states: "If it returns an HttpResponse object, Django won’t bother calling ANY other middleware or the appropriate view; it’ll return that HttpResponse.", but this is only true for any request, view, or exception middleware method. The remaining response middleware methods are still executed on the returned HttpResponse object.

Attachments

middleware-txt.diff (1.3 kB) - added by Jason Yan <tailofthesun@gmail.com> on 07/29/07 23:31:36.

Change History

07/29/07 23:05:22 changed by SmileyChris

  • needs_better_patch changed.
  • stage changed from Unreviewed to Accepted.
  • summary changed from Django Middleware documentation for process_request to Inaccurate middleware documentation for process_request.
  • needs_tests changed.
  • needs_docs set to 1.

Patches always welcome ;)

07/29/07 23:31:36 changed by Jason Yan <tailofthesun@gmail.com>

  • attachment middleware-txt.diff added.

07/29/07 23:32:43 changed by Jason Yan <tailofthesun@gmail.com>

  • has_patch set to 1.
  • summary changed from Inaccurate middleware documentation for process_request to Inaccurate middleware documentation for process_request and process_view.

Added patch -- I noticed the same thing for the process_view documentation.

07/30/07 16:33:20 changed by SmileyChris

  • needs_docs deleted.
  • stage changed from Accepted to Ready for checkin.

Thanks Jason

10/21/07 07:24:37 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6576]) Fixed #5013 -- Corrected the documentation about which how further middleware processing is done after request or view middleware returns something. Thanks, Jason Yan.

Add/Change #5013 (Inaccurate middleware documentation for process_request and process_view)




Change Properties
Action