Django

Code

Ticket #4968 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

assertRedirects doesn't respect query params

Reported by: Ivan Sagalaev <Maniac@SoftwareManiacs.Org> Assigned to: russellm
Milestone: Component: Testing framework
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

assertRedirects now parses out only a path from a redirect location and uses it to fetch a new response. Is there any reason why it leaves out query params? It doesn't work now for redirects like HttpResponseRedirect?('?name=value')

The fix is simple but I wanted to check if it's by design.

Attachments

4968.diff (5.0 kB) - added by Ivan Sagalaev <Maniac@SoftwareManiacs.Org> on 07/31/07 07:50:35.
Patch

Change History

07/26/07 06:08:59 changed by russellm

  • cc deleted.
  • needs_better_patch changed.
  • needs_tests set to 1.
  • owner changed from adrian to russellm.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

This is oversight. Patch and test case welcome.

07/31/07 07:50:35 changed by Ivan Sagalaev <Maniac@SoftwareManiacs.Org>

  • attachment 4968.diff added.

Patch

07/31/07 07:52:59 changed by Ivan Sagalaev <Maniac@SoftwareManiacs.Org>

  • has_patch set to 1.

Patch attached. One non-obvious point: I've replaced "urlparse" with "urlsplit" because the former splits an additional "parameter" part of a path which is not needed anyway.

07/31/07 09:22:32 changed by Simon G. <dev@simon.net.nz>

  • needs_tests deleted.
  • stage changed from Accepted to Ready for checkin.

Looks good, Ivan

08/31/07 06:37:28 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [6031]) Fixed #4968 -- Added assertRedirects handling for paths with GET data. Thanks for the patch, Ivan Sagalaev.

Add/Change #4968 (assertRedirects doesn't respect query params)




Change Properties
Action