Django

Code

Ticket #4964 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Brazilian local flavor new BRStateChoiceField

Reported by: Wiliam Alves de Souza Assigned to: nobody
Milestone: Component: django.contrib.localflavor
Version: SVN Keywords: localflavor
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

"A choice field that uses a list of Brazilian states as its choices."

Attachments

brlocalflavor.diff (11.4 kB) - added by wiliamsouza83@gmail.com on 07/24/07 19:48:25.
brlocalflavorv2.diff (3.7 kB) - added by Wiliam Alves de Souza on 08/13/07 09:31:26.
Changes based on Malcolm Tredinnick comments.

Change History

07/24/07 19:48:25 changed by wiliamsouza83@gmail.com

  • attachment brlocalflavor.diff added.

07/24/07 20:20:09 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

08/12/07 07:10:51 changed by mtredinnick

  • needs_better_patch set to 1.
  • stage changed from Ready for checkin to Accepted.

This isn't ready for checkin.

Please write a patch that only adds the new feature you are wanting. As a general rule, and particularly here, one change per ticket is the right approach.

As far as I can work out, the refactoring changes aren't really making anything clearer or better. They are just making it different. So I'd like to remove them from the patch and let's just look at the new feature.

08/13/07 09:31:26 changed by Wiliam Alves de Souza

  • attachment brlocalflavorv2.diff added.

Changes based on Malcolm Tredinnick comments.

08/20/07 04:53:19 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch deleted.
  • stage changed from Accepted to Ready for checkin.

08/20/07 04:53:50 changed by Simon G. <dev@simon.net.nz>

  • summary changed from Brazilian local flavor new BRStateChoiceField and code refactoring to Brazilian local flavor new BRStateChoiceField.

William - please feel free to open a new ticket with the proposed code refactoring.

09/14/07 02:19:38 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6176]) Fixed #4964 -- Added Brazilian state field to localflavors. Thanks, William Alves de Souza.

Add/Change #4964 (Brazilian local flavor new BRStateChoiceField)




Change Properties
Action