Django

Code

Ticket #4951 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

sites.RequestSite incorrectly reports domain

Reported by: Caleb Assigned to: nobody
Milestone: Component: Contrib apps
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

If you run the development server then sites.RequestSite? does not include the port number in the domain. This patch seems to fix the problem.

Attachments

models.diff (0.7 kB) - added by Caleb <jtxx000@yahoo.co.uk> on 07/21/07 23:22:03.

Change History

07/21/07 23:22:03 changed by Caleb <jtxx000@yahoo.co.uk>

  • attachment models.diff added.

07/21/07 23:43:58 changed by SmileyChris

  • needs_better_patch changed.
  • component changed from Uncategorized to Contrib apps.
  • needs_tests changed.
  • owner changed from jacob to adrian.
  • needs_docs changed.
  • stage changed from Unreviewed to Design decision needed.

I did wonder at why it was using SERVER_NAME over the get_host method. Not sure if it is by choice or not.

07/26/07 21:45:38 changed by SmileyChris

  • stage changed from Design decision needed to Accepted.

I'm going to accept. It does need #4986 to be applied first.

09/14/07 00:57:07 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Accepted to Ready for checkin.

#4986 is in, so I'm promoting this.

09/14/07 02:12:47 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6174]) Fixed #4951 -- Improved host retrieval in sites.models.RequestSite?. Thanks, Caleb.

Add/Change #4951 (sites.RequestSite incorrectly reports domain)




Change Properties
Action