Django

Code

Ticket #4947 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

large uploaded files cause a slow browser death in debug view

Reported by: eibaan@gmail.com Assigned to: adrian
Milestone: Component: Core framework
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 1

Description

The Django debug HTML page is great for finding bugs in templates and view functions. However, if you have an error in a view function with a request object that contains a - say - 200MB file object, well, then your browser dies a slow and painful death. At least my trusted Firefox does.

I've created a patch to suppress the file object in the debug view. There might be better ways to do this, I'm a Python beginner. This is the shortest and less intrusive way I could come up with.

Attachments

1.diff (1.3 kB) - added by eibaan@gmail.com on 07/21/07 06:23:46.

Change History

07/21/07 06:23:46 changed by eibaan@gmail.com

  • attachment 1.diff added.

07/21/07 09:00:40 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

Good idea, but patch may need improvement?

08/12/07 07:02:08 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5874]) Fixed #4947 -- Avoid displaying uploaded file contents in the debug web page. Based on a patch from eibaan@gmail.com.

Add/Change #4947 (large uploaded files cause a slow browser death in debug view)




Change Properties
Action