Django

Code

Ticket #4622 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

SelectDateWidget doesn't accept its as_hidden rendering

Reported by: Bill Fenner <fenner@gmail.com> Assigned to: adrian
Milestone: Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

An apparently little-known fact about widgets that implement get_value_from_datadict is that they need to be able to accept whatever the widget returns for its "as_hidden" value as input. Otherwise, a form that uses as_hidden to propogate values from previous forms will fail: 

>>> a = GetDate({'mydate_month':'4', 'mydate_day':'1', 'mydate_year':'2008'})
>>> print a['mydate'].as_hidden()
<input type="hidden" name="mydate" value="2008-4-1" id="id_mydate" />
>>> b=GetDate({'mydate':'2008-4-1'})
>>> print b.is_valid()
False

The attached diff has a fix for this problem, and a test.

Attachments

SelectDateWidget.diff (1.6 kB) - added by Bill Fenner <fenner@gmail.com> on 06/19/07 09:21:58.
A one-line diff and 29 lines of test ;-)

Change History

06/19/07 09:21:58 changed by Bill Fenner <fenner@gmail.com>

  • attachment SelectDateWidget.diff added.

A one-line diff and 29 lines of test ;-)

07/30/07 07:11:18 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

1:29 code:test ratio? how very agile of you :)

07/30/07 08:36:18 changed by Bill Fenner <fenner@gmail.com>

I was just tired of seeing needs_tests => 1 ;-)

08/11/07 21:15:36 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5859]) Fixed #4622 -- Fixed SelectDateWidget? to work correctly when used as a hidden input field. Thanks, Bill Fenner.

Add/Change #4622 (SelectDateWidget doesn't accept its as_hidden rendering)




Change Properties
Action