Opened 17 years ago
Closed 17 years ago
#4618 closed (fixed)
contrib.redirects has a small error in new_path handling
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Contrib apps | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As per http://www.djangoproject.com/documentation/redirects/, contrib.redirects should issue a HTTP GONE response when the new_path is empty. I'm probably the only one that uses this, but there's a small error in the Django code, where the redirect object is compared to an empty string instead of the new_path attribute.
Attached patch fixes it.
Attachments (1)
Change History (3)
by , 17 years ago
| Attachment: | redirect_patch.patch added |
|---|
comment:1 by , 17 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:2 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
(In [5494]) Fixed #4618 -- Fixed error in django.contrib.redirects new_path handling. Thanks, cephelo@…