Django

Code

Ticket #4618 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

contrib.redirects has a small error in new_path handling

Reported by: cephelo@gmail.com Assigned to: adrian
Milestone: Component: Contrib apps
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

As per http://www.djangoproject.com/documentation/redirects/, contrib.redirects should issue a HTTP GONE response when the new_path is empty. I'm probably the only one that uses this, but there's a small error in the Django code, where the redirect object is compared to an empty string instead of the new_path attribute.

Attached patch fixes it.

Attachments

redirect_patch.patch (501 bytes) - added by cephelo@gmail.com on 06/18/07 17:45:38.

Change History

06/18/07 17:45:38 changed by cephelo@gmail.com

  • attachment redirect_patch.patch added.

06/18/07 18:53:43 changed by SmileyChris

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

06/20/07 01:01:16 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [5494]) Fixed #4618 -- Fixed error in django.contrib.redirects new_path handling. Thanks, cephelo@gmail.com

Add/Change #4618 (contrib.redirects has a small error in new_path handling)




Change Properties
Action