How to use form_for_instance could benefit from more explanation

[toddobryan@…]

I've attached a patch.

[toddobryan@…]

patch including an extra paragraph of explanation for form_for_instance

[Chris Beaven]

Your description doesn't match the code, you actually create a new form class using form_for_instance and instantiate this in GET and POST.

[toddobryan@…]

You are absolutely correct. I'll fix this as soon as I can. Unfortunately, I'm at a hotel with not very reliable wireless service and can't access the SVN repository, so it will probably be Monday afternoon before I can get to it.

[toddobryan@…]

patch to clarify how to use form_for_instance

[toddobryan@…]

OK. The docs have been updated to match the code.

[Chris Beaven]

if request.method == 'POST': is actually the proper way to check for a POST call, the ticket is a bit messy adding in some ignores, and get_object_or_404 isn't a function of the Manager - it's a shortcut.

Maybe you could submit as a .diff or .patch too, that might fix trac not displaying the patch correctly.

Thanks :)

[toddobryan@…]

OK...

• request.method == 'POST'...check
• get_object_or_404() function fixed (big whoops on that)...check
• submitted as .patch, which does fix the display...check

I don't understand what you mean by "the ticket is a bit messy adding in some ignores," but will be happy to de-messify if you can clarify.

I don't know why you're being so picky about all these issues. If everything is perfect before it gets checked in, there won't be anything for anyone else to fix later. :-) Seriously, though, thanks for looking.

[Chris Beaven]

Don't worry, Adrian will still find lots to fix with it. I just go after the glaring mistakes ;)

[Malcolm Tredinnick]

(In [5988]) Fixed #4572 -- Added an example of form_for_instance usage in a full-fledged view. Based on a patch from toddobryan@….