Django

Code

Ticket #4403 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

[unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors

Reported by: hidded <me@hiddedpp.com> Assigned to: mtredinnick
Milestone: Component: Forms
Version: other branch Keywords: unicode
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Subj. Use form.as_p() if you want to see this bug.

Attachments

unicode-newforms-path.diff (0.8 kB) - added by hidded <me@hiddedpp.com> on 05/27/07 23:31:55.

Change History

05/27/07 23:31:55 changed by hidded <me@hiddedpp.com>

  • attachment unicode-newforms-path.diff added.

05/27/07 23:44:56 changed by mtredinnick

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

Thanks for the report.

That patch isn't the right solution because the force_unicode() call is needed for python 2.3. It does highlight that there's a bug further down when I don't call force_unicode() on bf_errors in the normal processing path, though.

The proper fix is to add a __unicode__ method to ErrorList, I suspect. I'll fix that shortly.

05/27/07 23:48:04 changed by mtredinnick

  • owner changed from adrian to mtredinnick.
  • summary changed from unicode: Form._html_output() crashed if errors_on_separate_row is True and form has errors to [unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors.

05/28/07 00:12:05 changed by hidded <me@hiddedpp.com>

  • keywords changed from unicode to unicode-branch unicode.

05/28/07 04:10:54 changed by mtredinnick

  • keywords changed from unicode-branch unicode to unicode.

Removing the unicode-branch keyword because I'm using that for bugs on trunk that are fixed on the branch. We know this ticket is for the unicode branch because of the [unicode] prefix in the summary.

05/28/07 08:02:16 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5375]) Fixed #4403 -- Stopped pushing form error messages (which are unicode strings) through a str method.

Add/Change #4403 ([unicode] Form._html_output() crashed if errors_on_separate_row is True and form has errors)




Change Properties
Action