Django

Code

Ticket #4367 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[unicode] debug.py: non ascii data in local vars

Reported by: Thomas Güttler <hv@tbz-pariv.de> Assigned to: mtredinnick
Milestone: Component: Internationalization
Version: other branch Keywords:
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Hi,

if there are non ascii values in the local vars, the debug template fails. Here is a patch.

Attachments

debug_py.diff (1.6 kB) - added by Thomas Güttler <hv@tbz-pariv.de> on 05/23/07 06:25:46.

Change History

05/23/07 06:25:46 changed by Thomas Güttler <hv@tbz-pariv.de>

  • attachment debug_py.diff added.

05/23/07 17:21:39 changed by mtredinnick

  • needs_better_patch changed.
  • component changed from Uncategorized to Internationalization.
  • needs_tests changed.
  • summary changed from unicode: debug.py: non ascii data in local vars to [unicode] debug.py: non ascii data in local vars.
  • version changed from SVN to other branch.
  • owner changed from jacob to mtredinnick.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

I don't like this patch. Having smart_unicode or anything like that leak up to the template level shouldn't be necessary. It's fixing the symptom, rather than the cause of the problem. I'll fix it some other way. Thanks for the report.

05/23/07 18:07:08 changed by mtredinnick

My apologies... that last comment sounds a lot more ungrateful than it was meant to be. I really do appreciate the bug report and the fact that you've posted an attempted fix (for a start, it points to one of the places where the problem is visible).

05/23/07 20:25:51 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5323]) unicode: Fixed #4367 -- Fixed a problem when trying to display some legitimately non-unicode, non-UTF-8 data. The workaround is probably a bit broad, but it shouldn't hurt in any unintended way I can think of.

Add/Change #4367 ([unicode] debug.py: non ascii data in local vars)




Change Properties
Action