Opened 18 years ago
Closed 18 years ago
#4323 closed (fixed)
[patch] Display author name without author email for RSS 2.0
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.syndication | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the current implementation, the RSS 2.0 generator does not write author name if the author has not an email. The patch fixes this problem.
Attachments (1)
Change History (6)
by , 18 years ago
comment:1 by , 18 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
Thanks for the patch, wangchun.
It looks valid but I'm not an expert in this area, so I'll forward to a design decision to make sure this is the way it should be done.
follow-up: 3 comment:2 by , 18 years ago
| Needs documentation: | set |
|---|---|
| Triage Stage: | Design decision needed → Accepted |
I thought I'd already triaged this -- apparently it was another one I just decided to do in my head and didn't get as far as the web browser. :-(
This change is fine. It's the accepted way to do this for RSS 2.0.
Needs a documentation update before it can go in (to syndication.txt).
comment:3 by , 18 years ago
| Needs documentation: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Replying to mtredinnick:
Needs a documentation update before it can go in (to syndication.txt).
But I suppose this patch introduces no documentation update, since it just added a missing feature for RSS 2.0. The Atom 1.0 generator had already have such support.
comment:4 by , 18 years ago
Hmm... you're right. Our syndication documentation is a bit lame in that it doesn't mention which features are required/implemented for which feed types in all cases.
comment:5 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
patch