Django

Code

Ticket #4323 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

[patch] Display author name without author email for RSS 2.0

Reported by: wangchun <yaohua2000@gmail.com> Assigned to: adrian
Milestone: Component: RSS framework
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

In the current implementation, the RSS 2.0 generator does not write author name if the author has not an email. The patch fixes this problem.

Attachments

4323.diff (1.1 kB) - added by wangchun <yaohua2000@gmail.com> on 05/17/07 03:29:11.
patch

Change History

05/17/07 03:29:11 changed by wangchun <yaohua2000@gmail.com>

  • attachment 4323.diff added.

patch

05/22/07 19:00:24 changed by SmileyChris

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

Thanks for the patch, wangchun.

It looks valid but I'm not an expert in this area, so I'll forward to a design decision to make sure this is the way it should be done.

(follow-up: ↓ 3 ) 05/22/07 19:10:23 changed by mtredinnick

  • needs_docs set to 1.
  • stage changed from Design decision needed to Accepted.

I thought I'd already triaged this -- apparently it was another one I just decided to do in my head and didn't get as far as the web browser. :-(

This change is fine. It's the accepted way to do this for RSS 2.0.

Needs a documentation update before it can go in (to syndication.txt).

(in reply to: ↑ 2 ) 05/23/07 00:55:32 changed by wangchun <yaohua2000@gmail.com>

  • needs_docs deleted.
  • stage changed from Accepted to Ready for checkin.

Replying to mtredinnick:

Needs a documentation update before it can go in (to syndication.txt).

But I suppose this patch introduces no documentation update, since it just added a missing feature for RSS 2.0. The Atom 1.0 generator had already have such support.

05/23/07 01:20:20 changed by mtredinnick

Hmm... you're right. Our syndication documentation is a bit lame in that it doesn't mention which features are required/implemented for which feed types in all cases.

05/26/07 05:36:37 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5357]) Fixed #4323 -- Added the ability to display author names without email addresses to RSS 2.0 feeds.

Add/Change #4323 ([patch] Display author name without author email for RSS 2.0)




Change Properties
Action