Django

Code

Ticket #4267 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

a bug in "The Django template language: For Python programmers"

Reported by: keisuke.nishida@gmail.com Assigned to: jacob
Milestone: Component: Documentation
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation:
Needs tests: Patch needs improvement:

Description

I have found a possible bug in the following page:

http://www.djangoproject.com/documentation/templates_python/#writing-the-compilation-function

You refer to "token.contents[0]" at several places in the sample code like this: 

def do_current_time(parser, token):
    try:
        # split_contents() knows not to split quoted strings.
        tag_name, format_string = token.split_contents()
    except ValueError:
        raise template.TemplateSyntaxError, "%r tag requires a single argument" % token.contents[0]

I believe "token.contents[0]" returns a single character, which is not very informative and not what you want here. Maybe it should have been "token.contents.split()[0]"?

The same applies to 0.95/0.96 docs.

Best regards,

Attachments

Change History

05/11/07 03:50:54 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5188]) Fixed #4267 -- In example code, extract the template tag name correctly in error messages where Token.split_contents() has failed. Thanks, keisuke.nishida@gmail.com.

Add/Change #4267 (a bug in "The Django template language: For Python programmers")




Change Properties
Action