Django

Code

Ticket #4176 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

DebugLexer breaks token source (breaking django exceptions)

Reported by: SmileyChris Assigned to: adrian
Milestone: Component: Template system
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

django.views.debug.get_template_exception_info expects the token source to be (origin, (start, end)): 

origin, (start, end) = exc_value.source

Malcolm's recent change in [5104] changed this to just (start, end) which is breaking Django's pretty exception view.

Patch attached.

Attachments

broken_token_source.patch (0.6 kB) - added by SmileyChris on 04/27/07 20:49:14.

Change History

04/27/07 20:49:14 changed by SmileyChris

  • attachment broken_token_source.patch added.

04/27/07 20:51:50 changed by SmileyChris

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

This is a rather urgent patch. The committer should be very careful to check my code, but I'm pretty sure my logic is sound.

04/27/07 23:45:38 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5116]) Fixed #4176 -- Fixed unintended change introduced in [5104]. Thanks, SmileyChris?.

Add/Change #4176 (DebugLexer breaks token source (breaking django exceptions))




Change Properties
Action