#4107 closed (fixed)
[patch] Localization stuff
| Reported by: | Owned by: | hugo | |
|---|---|---|---|
| Component: | Internationalization | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
- Corrects an error with bin/make-messages (because of missing dictionaries) in /contrib/admindocs/views.py
- Filter filesizeformat localizable
Attachments (2)
Change History (9)
by , 18 years ago
comment:1 by , 18 years ago
| Summary: | [patch] Localization stuff + updated french po file → [patch] Localization stuff |
|---|
Oops, french file will come in an other ticket.
comment:2 by , 18 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Are you marking the byte amount strings (e.g. "%f KB") for translation just so that the numbers are presented in the correct locale (1,234 vs. 1.234)? The strings KB, GB, etc, should not be marked for translation, since they are international abbreviations, hence it would be good to leave them out of the PO file to avoid confusion
If you could clarify what your intention is here, I'll fix it up when I commit this. No need to generate another patch.
comment:3 by , 18 years ago
Actually, KB is not as international as you think : BR
eg., in France, a "Byte" is an "octet" (even if it is not exactly the same thing, that is the word we use). So for us, "KB" is an English notation, we write "Ko". Some people may understand, just like they would understand "yes" or "no", but this is still not French.
by , 18 years ago
| Attachment: | diff.2.diff added |
|---|
a new string to translate in contrib/auth/models.py
comment:4 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 18 years ago
The admindocs directory does not exist on trunk -- only on the newforms-admin branch. Please open another ticket with that change (and put [newforms-admin] at the start of the title). We don't want to mix patches for trunk and patches from branches in one ticket, because they are handled by different people.
comment:7 by , 18 years ago
Thanks for the commit. Okay for the admindocs, sorry for the mistake, but I often forget that I am using newforms-admin ;-)
patch