Django

Code

Ticket #4107 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] Localization stuff

Reported by: Baptiste <baptiste.goupil@gmail.com> Assigned to: hugo
Milestone: Component: Internationalization
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

* Corrects an error with bin/make-messages (because of missing dictionaries) in /contrib/admindocs/views.py * Filter filesizeformat localizable

Attachments

diff.diff (2.6 kB) - added by Baptiste <baptiste.goupil@gmail.com> on 04/21/07 13:28:14.
patch
diff.2.diff (3.0 kB) - added by Baptiste <baptiste.goupil@gmail.com> on 04/22/07 02:09:56.
a new string to translate in contrib/auth/models.py

Change History

04/21/07 13:28:14 changed by Baptiste <baptiste.goupil@gmail.com>

  • attachment diff.diff added.

patch

04/21/07 13:28:46 changed by Baptiste <baptiste.goupil@gmail.com>

  • needs_better_patch changed.
  • summary changed from [patch] Localization stuff + updated french po file to [patch] Localization stuff.
  • needs_tests changed.
  • needs_docs changed.

Oops, french file will come in an other ticket.

04/21/07 19:58:39 changed by mtredinnick

  • stage changed from Unreviewed to Accepted.

Are you marking the byte amount strings (e.g. "%f KB") for translation just so that the numbers are presented in the correct locale (1,234 vs. 1.234)? The strings KB, GB, etc, should not be marked for translation, since they are international abbreviations, hence it would be good to leave them out of the PO file to avoid confusion

If you could clarify what your intention is here, I'll fix it up when I commit this. No need to generate another patch.

04/22/07 01:29:43 changed by Baptiste <baptiste.goupil@gmail.com>

Actually, KB is not as international as you think :[[ BR ]] eg., in France, a "Byte" is an "octet" (even if it is not exactly the same thing, that is the word we use). So for us, "KB" is an English notation, we write "Ko". Some people may understand, just like they would understand "yes" or "no", but this is still not French.

04/22/07 02:09:56 changed by Baptiste <baptiste.goupil@gmail.com>

  • attachment diff.2.diff added.

a new string to translate in contrib/auth/models.py

04/23/07 00:51:30 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5061]) Fixed #4107 -- Marked a few more strings for translation. Thanks, Baptiste.

04/23/07 00:52:45 changed by anonymous

The admindocs directory does not exist on trunk -- only on the newforms-admin branch. Please open another ticket with that change (and put [newforms-admin] at the start of the title). We don't want to mix patches for trunk and patches from branches in one ticket, because they are handled by different people.

04/23/07 00:54:32 changed by mtredinnick

Oops... last comment was by me.

04/23/07 04:35:45 changed by Baptiste <baptiste.goupil@gmail.com>

Thanks for the commit. Okay for the admindocs, sorry for the mistake, but I often forget that I am using newforms-admin ;-)

Add/Change #4107 ([patch] Localization stuff)




Change Properties
Action