Django

Code

Ticket #4101 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Confusing URL match in generic views examples

Reported by: Collin Grady <cgrady@the-magi.us> Assigned to: jacob
Milestone: Component: Documentation
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

On http://www.djangoproject.com/documentation/generic_views/ there's a URL match using r'/?$' which could cause confusion to new users - as the preceding slash is never sent to urlpatterns, that /? is completely extraneous, but may make people think that sometimes it is sent.

Attachments

generic_views.patch (0.8 kB) - added by Collin Grady <cgrady@the-magi.us> on 04/20/07 19:35:30.
generic_views.2.patch (0.8 kB) - added by Collin Grady <cgrady@the-magi.us> on 04/20/07 19:36:14.
minor correction to last patch

Change History

04/20/07 19:35:30 changed by Collin Grady <cgrady@the-magi.us>

  • attachment generic_views.patch added.

04/20/07 19:36:14 changed by Collin Grady <cgrady@the-magi.us>

  • attachment generic_views.2.patch added.

minor correction to last patch

04/20/07 22:01:14 changed by mtredinnick

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

What do you mean confusing to "new users"? I had to think about this for a little while to work out what it might be doing. I agree, it's worth fixing.

04/20/07 23:21:46 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5050]) Fixed #4101 -- Clarified a potentially confusing URL pattern in one example. Thanks, Collin Grady.

Add/Change #4101 (Confusing URL match in generic views examples)




Change Properties
Action