Django

Code

Ticket #4081 (closed: fixed)

Opened 1 year ago

Last modified 3 months ago

Allow blank and null content fields for flatpages

Reported by: mrmachine Assigned to: nobody
Milestone: Component: Contrib apps
Version: SVN Keywords: flatpages blank null content dbchange
Cc: real.human@mrmachine.net Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

some flatpages not not need any actual content pulled from the database if they are using a custom template (depending on the design of the page). allowing blank/null content fields would avoid having to put irrelevent content into the database just to circumvent the validation.

Attachments

blank-flatpages.diff (0.9 kB) - added by ctrochalakis on 01/10/08 07:11:11.
Allow blank flatpages content
blank-flatpages-with-documentation.diff (1.5 kB) - added by mcroydon on 03/17/08 15:52:53.
Added note about new functionality in the documentation; also swapped out chicagocrime link for everyblock link

Change History

04/19/07 01:25:30 changed by mrmachine <real dot human at mrmachine dot net>

  • cc set to real.human@mrmachine.net.
  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

04/21/07 07:53:25 changed by Simon G. <dev@simon.net.nz>

  • summary changed from allow blank and null content fields for flatpages to Allow blank and null content fields for flatpages.
  • stage changed from Unreviewed to Design decision needed.

09/16/07 14:14:54 changed by ubernostrum

This would be backwards-incompatible, and if all you want is a custom template at a given URL the direct_to_template generic view is probably a better option, so I'd be -1 on this.

(follow-up: ↓ 5 ) 10/23/07 00:09:26 changed by Tai Lee <real.human@mrmachine.net>

direct_to_template would required urls.py to be changed and the server restarted each time a new page is added. Flatpages allows staff admin users to create and delete pages without changing urls.py or restarting the server. Where's the harm in allowing blank content? How is that even backwards incompatible? As long as null=False stays, no existing sites should break by adding blank=True...?

(in reply to: ↑ 4 ) 11/27/07 03:40:13 changed by irlkersten@gmail.com

This ticket has been open since 7 months. Who can make design decisions such as these? Is there anything I could do to help in such a case?

12/02/07 14:37:43 changed by jacob

  • keywords changed from flatpages blank null content to flatpages blank null content dbchange.
  • stage changed from Design decision needed to Accepted.

01/10/08 07:11:11 changed by ctrochalakis

  • attachment blank-flatpages.diff added.

Allow blank flatpages content

01/10/08 07:15:22 changed by ctrochalakis

  • has_patch set to 1.

I have tested it with content set to blank and seems to work as expected.

03/17/08 15:52:53 changed by mcroydon

  • attachment blank-flatpages-with-documentation.diff added.

Added note about new functionality in the documentation; also swapped out chicagocrime link for everyblock link

03/17/08 15:59:26 changed by mcroydon

  • stage changed from Accepted to Ready for checkin.

Marking ready for checkin per jkocherhans.

06/30/08 08:05:48 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7807]) Fixed #4081 -- Allow empty content in flatpages. Patch from ctrochalakis and Matt Croydon.

Add/Change #4081 (Allow blank and null content fields for flatpages)




Change Properties
Action