implicitly control in paginator causes unexpected return values.

[meren@…]

Hi,

Pagiantor doesn't check the 'page_number' value in "has_next_page" and "has_previous_page" functions. It causes this:

>>> from django.core.paginator import ObjectPaginator
>>> from zangetsu.blog.models import Entry
>>> e = Entry.objects.all()
>>> len(e)
262
>>> paginator_result = ObjectPaginator(e, 10)
>>> paginator_result.pages
27
>>> page_number = 0
>>> paginator_result.has_next_page(page_number)
True
>>> paginator_result.has_previous_page(page_number)
False
>>> page_number = "0"
>>> paginator_result.has_next_page(page_number)
False
>>> paginator_result.has_previous_page(page_number)
True

Please review the patch attached below (I'm sorry if ticket is in the wrong component, I couldn't find any closer).

Thanks,

1. Murat Eren.

[Brian Rosner <brosner@…>]

I think in this case that the type conversion should be done before passing it in to has_*_page methods. These methods shouldn't care where the data came from.