Django

Code

Ticket #3986 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

Add Indian Localflavour

Reported by: pradeep.gowda@gmail.com Assigned to: adrian
Milestone: Component: django.contrib.localflavor
Version: SVN Keywords: localflavor, l10n, in, ind
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 1 Patch needs improvement: 0

Description

Patch to add a module to django.contrib.localflavor for India: INStateSelect and INZipCodeField.

note: The directory name is ind instead of two letter in as it conflicts with python keyword in.

Attachments

indianlocalflavour.diff (4.3 kB) - added by pradeep.gowda@gmail.com on 04/10/07 02:45:13.
initial diff file attached.
in_localflavor.diff (4.3 kB) - added by Simon G. <dev@simon.net.nz> on 07/30/07 07:21:18.
renamed ind/ to in_/ in the original patch to comply with PEP8

Change History

04/10/07 02:45:13 changed by pradeep.gowda@gmail.com

  • attachment indianlocalflavour.diff added.

initial diff file attached.

04/11/07 05:35:17 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

04/12/07 08:25:55 changed by russellm

  • needs_better_patch set to 1.
  • needs_tests set to 1.

To comply with PEP8, the name of this module should be 'in_', not 'ind'.

04/13/07 06:33:02 changed by russellm

  • stage changed from Ready for checkin to Accepted.

07/30/07 07:21:18 changed by Simon G. <dev@simon.net.nz>

  • attachment in_localflavor.diff added.

renamed ind/ to in_/ in the original patch to comply with PEP8

07/30/07 07:21:55 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch deleted.
  • stage changed from Accepted to Ready for checkin.

08/11/07 05:04:19 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5847]) Fixed #3986 -- Added Indian localflavor. Thanks, pradeep.gowda@gmail.com.

08/11/07 13:09:33 changed by C8E

  • status changed from closed to reopened.
  • resolution deleted.

Malcolm, you did apply the patch in django/contrib/in_ , not in django/contrib/localflavor/in_ . Is that intentional?

08/11/07 19:33:10 changed by mtredinnick

Nope, not intentional. I screwed up. :-(

Good catch. I'll fix it.

08/11/07 20:19:55 changed by mtredinnick

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [5856]) Moved in_ directory to its correct location under localflavor. I committed it in the wrong place in [5847]. Fixed #3986.

08/12/07 18:22:01 changed by Simon G. <dev@simon.net.nz>

  • status changed from closed to reopened.
  • resolution deleted.

My fault sorry - should have updated the patch to the right dir. Malcolm - the in_ dir. is still in django/contrib/ but empty. Can this be removed?

08/12/07 19:53:50 changed by Simon G. <dev@simon.net.nz>

  • status changed from reopened to closed.
  • resolution set to fixed.

Already well ahead of me - fixed in [5879]

Add/Change #3986 (Add Indian Localflavour)




Change Properties
Action