Django

Code

Ticket #3957 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

BRCPFField LocalflavorBR

Reported by: danielvaz@gmail.com Assigned to: adrian
Milestone: Component: django.contrib.localflavor
Version: SVN Keywords: brcpffield, localflavor, br
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 1

Description

A new implementation of BRCPFField was made with the code style of BRCNPJField, but the fields NOT like same.

Attachments

tests_br_cpffield.diff (2.0 kB) - added by danielvaz@gmail.com on 04/07/07 14:58:25.

Change History

04/07/07 14:58:25 changed by danielvaz@gmail.com

  • attachment tests_br_cpffield.diff added.

04/07/07 17:30:20 changed by danielvaz@gmail.com

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

I try send the patch (I already send the tests) but this is marked as spam. How to solve this?

04/08/07 21:24:58 changed by adrian

  • component changed from Contrib apps to django.contrib.localflavor.

04/08/07 21:41:20 changed by danielvaz@gmail.com

Internal Error Submission rejected as potential spam (Akismet says content is spam)

How to solve it? How do I can send the BRCPFField?

The tests of BRCPFField has been send.

04/11/07 05:48:42 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Unreviewed to Accepted.

Sorry, everyone's having a few issues with Trac choking on binaries coming through the spam filter. Can you try to attach it again, and if that doesn't work, paste it onto dpaste.com (remember to check "hold"!) and put a link in.

Thanks :)

04/12/07 06:31:54 changed by danielvaz@gmail.com

I try once more, but it's dont work. So i post in dpaste.com as recomended.

http://dpaste.com/hold/8364/

I'm waiting for answers now.

Thanks

04/12/07 14:59:39 changed by Simon G. <dev@simon.net.nz>

  • has_patch set to 1.
  • stage changed from Accepted to Ready for checkin.

04/20/07 04:00:52 changed by mtredinnick

  • needs_better_patch set to 1.
  • stage changed from Ready for checkin to Accepted.

This class needs at least some documentation to explain what it does. The fields in localflavor should at least be vaguely understandable to people outside that locale and doing a Google search for BRCPF doesn't turn up anything relevant in the first few hits. Please put a small docstring at the top of the class explaining what the field is used for (perhaps with a reference to an English-language web page explaining what it is -- e.g. wikipedia -- if possible).

Also, you cannot use unicode strings inside gettext() reliably -- this is a constraint in Python not in Django (although Django will soon add ugettext() support). They will break if they contain non-ASCII characaters. So best to remove the u"..." markers and just use normal strings there.

04/20/07 21:29:22 changed by danielvaz@gmail.com

Doc String added. References from wikipedia added. u"strings" removed.

http://dpaste.com/hold/8833/

I'm waiting for your answer, mtredinnick. Thank you.

04/25/07 12:13:16 changed by danielvaz@gmail.com

This patch will be apply at SVN version?

04/25/07 17:39:11 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Accepted to Ready for checkin.

(follow-up: ↓ 12 ) 04/26/07 08:11:07 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5089]) Fixed #3957, #3945 -- Added CPF and CNPJ (some Brazilian identity numbers) fields to the Brazilian localflavor. Thanks, onaiort@gmail.com and danielvaz@gmail.com.

(in reply to: ↑ 11 ) 04/26/07 11:39:49 changed by danielvaz@gmail.com

You forgot tests_br_cpffield.diff (tests/regressiontests/forms/localflavor.py). Do I can reopen the ticket or no? I'm waiting your answer.

Thanks - Daniel Alves Barbosa de Oliveira Vaz

04/27/07 07:50:24 changed by mtredinnick

(In [5108]) Added tests for Brazilian CRPF field that were accidentally omitted in [5089]. Refs #3957.

Add/Change #3957 (BRCPFField LocalflavorBR)




Change Properties
Action