compile-messages.py could use LOCALE_PATHS from settings.py

[Olivier Ricou <ricou@…>]

Why compile-messages.py does not use the LOCALE_PATHS variable defined in settings.py
to define the basedir directory ? Now we are restricted to locale and conf/locale.

[Malcolm Tredinnick]

Good point. This would be a reasonable fix to make: have compile-messages.py also compile PO files under the directories in LOCALE_PATHS.

[Ilya Semenov]

Here it goes.

[Malcolm Tredinnick]

(In [6349]) Fixed #3955 -- Added the ability to traverse LOCALE_PATHS when compiling PO files. Thanks, semenov.

[Wang Chun <wangchun@…>]

bugfix for r6349

[anonymous]

I reopened this ticket because of a bug in r6349.

I have runtime error with compile-messages.py:

Traceback (most recent call last):
  File "/home/wangchun/src/django/django/bin/compile-messages.py", line 64, in <module>
    main()
  File "/home/wangchun/src/django/django/bin/compile-messages.py", line 61, in main
    compile_messages(options.locale)
  File "/home/wangchun/src/django/django/bin/compile-messages.py", line 17, in compile_messages
    basedirs += settings.LOCALE_PATHS
  File "/home/wangchun/src/cityweekend/lib/django/django/conf/__init__.py", line 32, in __getattr__
    return getattr(self._target, name)
AttributeError: 'Settings' object has no attribute 'LOCALE_PATHS'

I have attached a patch for this.

[Wang Chun <wangchun@…>]

bugfix for r6349

[Wang Chun <wangchun@…>]

sorry, stupid mistake...

plz use bugfix_for_r6349.2.diff instead.

[Ilya Semenov]

Agreed. However, they tend to use hasattr() approach instead of try/except in Django code, so the patch should look a bit different.

[Ilya Semenov]

A bugfix to a patch by Wang Chun, uses hasattr() instead of try/except

[Malcolm Tredinnick]

(In [6447]) Fixed #3955 -- Handled the case when there is no LOCALE_PATHS setting from [6349]. Thanks, Wang Chun and semenov.