Django

Code

Ticket #3929 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

newforms textarea widget produces invalid HTML by default

Reported by: lukeplant Assigned to: adrian
Milestone: Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

"cols" and "rows" are required attributes for textarea, and not included in default output of the newform widget. The attached patch fixes this, with updates to tests.

(I actually have commit access, but I wanted this to go through someone else, as I've not been around for a while and I don't know much about newforms)

Attachments

textarea_validity.patch (6.0 kB) - added by lukeplant on 04/04/07 16:30:20.
Patch for textarea output and corresponding tests

Change History

04/04/07 16:30:20 changed by lukeplant

  • attachment textarea_validity.patch added.

Patch for textarea output and corresponding tests

04/04/07 16:37:29 changed by lukeplant

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

By the way, I meant to mention that the default values I've chosen are the ones used by oldforms.LargeTextField?

04/08/07 20:22:45 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [4961]) Fixed #3929 -- Newforms Textarea widget now always includes 'rows' and 'cols' attributes, even if you don't pass them in, for HTML correctness. Thanks, and welcome back, Luke Plant

Add/Change #3929 (newforms textarea widget produces invalid HTML by default)




Change Properties
Action