#3899 closed (duplicate)
Building RPM fails for 0.96 (python setup.py bdist_rpm)
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Core (Other) | Version: | 0.96 |
Severity: | Keywords: | setup | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
There seems to be a mismatch between the version number generated by the setup.py file and the one it should be using. This causes python setup.py bdist_rpm to fail. I've attached a patch that fixes the problem.
Attachments (1)
Change History (4)
by , 18 years ago
Attachment: | fix-setup-version-info.patch added |
---|
comment:1 by , 18 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Duplicate of the outstanding issue of #3338.
comment:2 by , 18 years ago
By the way, there are two problems with this patch:
- It doesn't tell us which file to patch (although I could work it out, because I know the problem you are trying to solve). In future, please generate patches from the top of the tree so that it includes the full path information. And use the "-u" option to get a unifed diff, because it's a bit shorter in most cases.
- It tries to fix the problem by making the real version number a bit less readable (humans are more used to reading dashes in strings than underscores). The fix has to be in the rpm package number generation, not by changing Django's version number to something that reads less like a nomrmal number string. That is why #3338 is still open.
comment:3 by , 18 years ago
My apologies... your patch does indeed try to fix the right area if it is meant to applied to setup.py. Still not quite right, though and a dupe of #3338, but I didn't want to leave the impression it was totally ridiculous.
Patch to fix setup bdist_rpm target