Django

Code

Ticket #3870 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

a couple widgets not passing along attrs to render()

Reported by: Gary Wilson <gary.wilson@gmail.com> Assigned to: adrian
Milestone: Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 1 Patch needs improvement: 0

Description

RadioSelect is setting a local variable in its render() method without touching self.attrs: 

attrs = attrs or {}

and MultiWidget doesn't touch self.attrs either before calling render() on each Widget.

Attachments

3870.diff (1.4 kB) - added by Gary Wilson <gary.wilson@gmail.com> on 03/29/07 16:38:35.
use self.build_attrs

Change History

03/29/07 16:38:35 changed by Gary Wilson <gary.wilson@gmail.com>

  • attachment 3870.diff added.

use self.build_attrs

03/29/07 16:39:31 changed by Gary Wilson <gary.wilson@gmail.com>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Accepted.
  • needs_tests set to 1.
  • needs_docs changed.

04/19/07 23:39:31 changed by Gary Wilson <gary.wilson@gmail.com>

#4080 marked as duplicate. That ticket's patch also added the attributes to the <ul> produced by RadioFieldRenderer, but maybe that could be a separate ticket as that is a new feature, whereas this is a bug fix.

04/24/07 07:53:30 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [5065]) Fixed #3870, Refs #3787 -- Fixed handling of widget attributes on RadioSelect? and MultiWidget?. In particular, handling of the id attribute has been fixed. Thanks to Gary Wilson and Max Derkachev.

Add/Change #3870 (a couple widgets not passing along attrs to render())




Change Properties
Action